Add: Install, Pack (windows) and Release workflow #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
reviewed
Nov 29, 2023
docs/CMakeLists.txt
Outdated
| cmake_minimum_required(VERSION 3.5) | ||
|
|
||
| install(FILES | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/grfcodec.1 |
rubidium42
reviewed
Dec 12, 2023
generate_version.cmake
Outdated
| if(WRITE_VERSION) | ||
| file(WRITE .version "${GIT_VERSION}\t${GIT_DATE}\n") | ||
| else() | ||
| message(STATUS "Generating version.h") |
There was a problem hiding this comment.
Weird alignment of this line compared to the rest.
rubidium42
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally decided to add some missing stuff in cmake files to allow installing and bundling.
Bundling is done only for windows.
But source and windows builds should be a good starting point to be able to do releases on github.
Tested on my fork https://github.com/glx22/grfcodec/releases/tag/7.0.0