Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poll display on delegation settings change #3790

Conversation

bastianjoel
Copy link
Member

resolves #3685

Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The polls are still not loaded correctly => no change in behaviour

having any poll in the autopilot (e.g. a running poll) results in several Errors being thrown in the console

base-repository.ts:396 ERROR 
TypeError: Cannot read properties of undefined (reading 'length')
    at AssignmentPollVoteComponent_ng_template_1_ng_container_1_ng_container_1_div_3_div_2_b_2_Template (base-poll-vote.component.html:67:29)
    at executeTemplate (core.mjs:11966:13)
    at refreshView (core.mjs:13461:13)
    at detectChangesInView (core.mjs:13626:9)
    at detectChangesInEmbeddedViews (core.mjs:13569:13)
    at refreshView (core.mjs:13485:9)
    at detectChangesInView (core.mjs:13626:9)
    at detectChangesInEmbeddedViews (core.mjs:13569:13)
    at refreshView (core.mjs:13485:9)

or a different example

auth-check.service.ts:93 ERROR 
TypeError: Cannot read properties of undefined (reading 'includes')
    at MotionPollVoteComponent.defineVoteOptions (base-poll-vote.component.ts:499:42)
    at MotionPollVoteComponent.updatePoll (base-poll-vote.component.ts:438:14)
    at set poll (base-poll-vote.component.ts:46:14)
    at writeToDirectiveInput (core.mjs:12852:34)
    at setInputsForProperty (core.mjs:13086:9)
    at elementPropertyInternal (core.mjs:12377:9)
    at Module.ɵɵproperty (core.mjs:16218:9)
    at PollCollectionComponent_ng_template_2_div_8_os_motion_poll_vote_1_Template (poll-collection.component.html:31:38)
    at executeTemplate (core.mjs:11966:13)

@Elblinator Elblinator assigned bastianjoel and unassigned Elblinator Jun 27, 2024
@Elblinator
Copy link
Member

The Error message seems to be not related to this issue. I just got the same Error while checking out main
I'll investigate the Error further and create new Issues

@bastianjoel
Copy link
Member Author

The Error message seems to be not related to this issue. I just got the same Error while checking out main I'll investigate the Error further and create new Issues

Could you approve in that case?

@bastianjoel bastianjoel assigned Elblinator and unassigned bastianjoel Jul 3, 2024
@Elblinator Elblinator self-requested a review July 3, 2024 07:00
@Elblinator Elblinator merged commit 89b1ef5 into OpenSlides:main Jul 3, 2024
5 checks passed
@bastianjoel bastianjoel deleted the 3685-fix-poll-delegation-setting-change branch July 3, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix polls when delegation settings are changed
2 participants