Fix visibility of participant list singleitem menu #3541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
This issue is not about, what is seen in the @Elblinator please retest, and for the other stuff open a new issue. |
Elblinator
reviewed
Apr 15, 2024
| @@ -454,6 +454,10 @@ export class ParticipantListComponent extends BaseMeetingListViewComponent<ViewU | |||
| await this.repo.removeUsersFromMeeting([user]); | |||
| } | |||
|
|
|||
| public canSeeSingleItemMenu(user: ViewUser): boolean { | |||
| return this.operator.hasPerms(Permission.userCanManage) || this.canChangePassword(user); | |||
There was a problem hiding this comment.
please change to this.operator.hasPerms(Permission.userCanUpdate)
Elblinator
requested changes
Apr 15, 2024
There was a problem hiding this comment.
Please change the permission
I'll create a new Issue for my previous CR
#3558
|
okay, I have changed the permission check in canSeeSingleItemMenu. |
bastianjoel
approved these changes
Apr 16, 2024
Elblinator
approved these changes
Apr 18, 2024
bastianjoel
pushed a commit
to bastianjoel/openslides-client
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #3486