Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide submitters dropbox in motion create if cannot see users #4484

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Hide submitters dropbox in motion create if cannot see users #4484

wants to merge 5 commits into from

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented Dec 12, 2024

@reiterl reiterl added the bug label Dec 12, 2024
@reiterl reiterl added this to the 4.3 milestone Dec 12, 2024
Elblinator
Elblinator requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please change the helpText: _(Requires permission to manage motions), to helpText: _(Requires permission to manage motion metadata)

  • hide the new h3 "Submitters" if a person is not allowed to change meta data

@Elblinator Elblinator assigned reiterl and unassigned bastianjoel and Elblinator Dec 12, 2024
@reiterl reiterl requested a review from Elblinator December 13, 2024 07:30
@reiterl reiterl assigned bastianjoel and Elblinator and unassigned reiterl Dec 13, 2024
@reiterl
Copy link
Member Author

reiterl commented Dec 13, 2024

Updated, new helptext of the meeting setting and changed the visibility of the submitters label.

Elblinator
Elblinator approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function

@Elblinator Elblinator removed their assignment Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elblinator Elblinator Elblinator approved these changes

@bastianjoel bastianjoel Awaiting requested review from bastianjoel

Assignees

@bastianjoel bastianjoel

Labels
bug
Projects
None yet
Milestone
4.3
3 participants
@reiterl @Elblinator @bastianjoel