Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motion detail view: Amendments Display error #4426

Closed
MSoeb opened this issue Nov 29, 2024 · 1 comment · Fixed by #4472
Closed

Motion detail view: Amendments Display error #4426

MSoeb opened this issue Nov 29, 2024 · 1 comment · Fixed by #4472
Assignees
Milestone

Comments

@MSoeb
Copy link

MSoeb commented Nov 29, 2024

Describe the bug
Motions with amendments have display errors in the 'Show all changes' function. If amendments are not displayed in the motion, you can use this function to show the amendments. This works correctly. The error now occurs if you activate the amendments via 'Show all changes', then click on the motions menu and open the motion again, the amendments are visible even though the 'Show all changes' checkbox is not checked. The browser seems to remember the activated setting.

This also occurs if another menu instead of motions is opened.

Example - The amendment is visible, but the checkbox is not marked:
image

How to Reproduce
Steps to reproduce the behavior:

  1. open a meeting
  2. open motions and create a motion with an amendment
  3. open the motion detail view and check 'show all changes'. The amendment should now be visible.
  4. open motions menu
  5. open motion -> Amendment is visibile and 'Show all changes' box is not marked

Expected behavior
When switching from a motion with activated 'Show All Changes' function to another menu and back to the motion, the browser should not have remembered the previously set checkmark. When reopening the motion, the amendments should not be visible if the check mark is not set.

Important: It is possible for amendments to be permanently displayed in the motion. This should continue to behave as usual and is excluded from this bug fix.

@MSoeb MSoeb added the bug label Nov 29, 2024
@MSoeb MSoeb added this to the 4.2 milestone Nov 29, 2024
@emanuelschuetze
Copy link
Member

This error was introduced with 4.1.17 - maybe with the motion detail refactoring?

@rrenkert rrenkert modified the milestones: 4.2, 4.3 Dec 9, 2024
@Elblinator Elblinator modified the milestones: 4.3, 4.2 Dec 9, 2024
@bastianjoel bastianjoel self-assigned this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants