Motion detail view with amendments: Changing amendment status needs reload

[MSoeb]

Describe the bug
It is possible to change the status of an amendment in the motion detail view, but the change is not displayed. The status switches up, but the old status is still displayed. An update that updates the visulization seems to be missing here.

How to Reproduce
Steps to reproduce the behavior:

1. open a meeting
2. open motions > create a motion with an amendment
3. open the motion in the detail view
4. mark the checkbox 'Show all changes' > try to change the amendment status via the three-dot-menu behind the amendment

Expected behavior
Changing the amendmend status via the three-dot-menu should have visual effect. New status should be immediately visible

[bastianjoel]

Cannot reproduce

[Elblinator]

Reproduction:

1. Create amotion
2. Create Two Amendments
3. Navigate to the motion detail view
4. Tick "Show all changes" box
5. Update state from amendment

I have the theory that the states update if you update the state from every amendment
If you update the second amendment in after step 5 then the states on the page update

[reiterl]

It seems like the changes in the MotionDetailDiffComponent doesn't change after a setAmendmentState or a resetAmendmentState.

[reiterl]

The AmendementControlerService has a strange timestamplogic in getViewModelListObservableFor() in it, which breaks the stuff.

[bastianjoel]

Fix should be applied to motion-change-recommendation-controller.service.ts too.

[bastianjoel]

While at it my comments in #4412 should also be implemented. Might be a good idea to add an helper for changed checks for view model lists.

Also it might need to be checked if viewModelUpdateTimestamp works correctly or if there are any cases in the base repo where the proxy object is skipped.

[reiterl]

Yes, nice idea. Deassigned.