Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last send mail: Info icon can be seen accross meetings without correct permission per meeting #3596

Closed
MSoeb opened this issue Mar 27, 2024 · 5 comments · Fixed by #3597
Closed
Assignees
Labels
Milestone

Comments

@MSoeb
Copy link

MSoeb commented Mar 27, 2024

Description: If a user is part of several meetings and has different group permissions per meeting, he will see the last send mail icon accross all meetings, if he had the permission in at least one meeting. The information is somehow wrongly saved and available accross all meetings if the user has the permission to see the participant menu in a meeting.

Reproduction:

  • needed: two meetings, same two users in each meeting
  1. open meeting A
  2. Add user 1 to group "Staff" and user 2 to "delegates".
  3. send user 2 an invitation mail.
  4. Login as user 1: User 1 should see now an icon in the participant menu. (correct)
  5. open meeting B
  6. Add user 1 and 2 to group "delegates".
  7. Login as user 1: In the participant menu, the mail icon should be behind user 2. (incorrect)

What should happen:
The permission to see last send mail data should only be visible, if the user has the correct permission to see it. This should based on group permissions per meeting.

@MSoeb MSoeb added the bug label Mar 27, 2024
@MSoeb MSoeb changed the title Last send mail: Info icon can be seen accross meeting without permission per meeting Last send mail: Info icon can be seen accross meetings without permission per meeting Mar 27, 2024
@MSoeb MSoeb changed the title Last send mail: Info icon can be seen accross meetings without permission per meeting Last send mail: Info icon can be seen accross meetings without correct permission per meeting Mar 27, 2024
@MSoeb MSoeb added this to the 4.2 milestone Mar 27, 2024
@reiterl
Copy link
Member

reiterl commented Apr 17, 2024

This is a problem with the AU restricter. See in the participant permissions there.
User A can see last sent of user B if there is one meeting with B in the meeting and A is allowed to see last email sent in that meeting.

@rrenkert rrenkert transferred this issue from OpenSlides/openslides-client Apr 17, 2024
@ostcar
Copy link
Member

ostcar commented Apr 17, 2024

I don't see, how this is a bug

@jsangmeister
Copy link
Contributor

jsangmeister commented Apr 18, 2024

I think @ostcar is correct. To add some background, the field user/last_email_sent is a user field and not a meeting_user field, so it has to be determined from a global context whether another user can see it and not from a meeting specific context. Therefore, the only option is the one implemented. If we want, the client can go ahead and restrict it additionally to not confuse users in regards to the setting, but in the scenario from @reiterl above user A will always be able to switch to the meeting where they have the required permission and view the field's content there.

@reiterl
Copy link
Member

reiterl commented Apr 22, 2024

So, should we close this issue as "won't fix"?

@rrenkert rrenkert transferred this issue from OpenSlides/openslides-autoupdate-service Apr 23, 2024
@jsangmeister
Copy link
Contributor

The client should hide the field if the operator does not have the required permission in the current meeting, even if the restrictor allows to see the field because of permissions in other meetings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants