Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Username visible if can_see_sensible_data ist true #3548

Closed
Elblinator opened this issue Apr 11, 2024 · 5 comments · Fixed by #3598
Closed

Make Username visible if can_see_sensible_data ist true #3548

Elblinator opened this issue Apr 11, 2024 · 5 comments · Fixed by #3598
Assignees
Labels
enhancement General enhancement which is neither bug nor feature
Milestone

Comments

@Elblinator
Copy link
Member

Elblinator commented Apr 11, 2024

Current behaviour:
Even if a person is allowed to see sensible data the Username in the participant-list will never be displayed

Reproduction:

  1. login as an admin
  2. navigate to a participant list
  3. create a participant without surname and firstname and only username; save
  4. navigate back into the participant-list
  5. User ## will be displayed in the participant-list

Wanted behaviour:
Given that a participant has the permission to see the username:
In the participant-list:
The display should be like the display in the account list
account-list:
accound-list
participant-ist:
participant-list
(description: the username should be displayed under the other name, if vote weight is activated then the username should be on the most left hand side and vote weight and name should be separated with a middot)

Several snackbars, views or pages:
with diverse actions you can see the string "User ##" so far I cannot identify an actual loss of functionality IF the username is also additionally displayed in the participant-list. this may need some revisiting after the participant-list is fixed. But this should be done is a separate Issue then.

@Elblinator Elblinator added the bug label Apr 11, 2024
@Elblinator Elblinator added this to the 4.2 milestone Apr 11, 2024
@reiterl
Copy link
Member

reiterl commented Apr 15, 2024

I tried to add the operator and a perm check to the getName method in user-repository. But it broke the app.
The login screen was no longer visible. I wont continue here.

@Elblinator Elblinator assigned Elblinator and unassigned Elblinator Apr 15, 2024
@bastianjoel
Copy link
Member

bastianjoel commented Apr 16, 2024

This is intended behavior. See for reference #3464.
The reasoning to remove the username from displaying as fallback was that in real instances first and lastname are normally always set.

@bastianjoel
Copy link
Member

If you still want to change this see #3489

@jsangmeister
Copy link
Contributor

I second that this is not necessary. Users with can_see_sensitive_data can still see the usernames on the detail page of the user. Implementing a permission check in the user repo does not sound feasible and workarounds or alternative solutions will require more work than what this issue is worth.

@Elblinator Elblinator removed their assignment Apr 18, 2024
@Elblinator
Copy link
Member Author

(23.04.24)
I updated the wanted behaviour

@bastianjoel bastianjoel added feature and removed bug labels Apr 23, 2024
@rrenkert rrenkert added enhancement General enhancement which is neither bug nor feature and removed feature labels Apr 23, 2024
@reiterl reiterl self-assigned this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement which is neither bug nor feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants