Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Participant import: importing standards groups in different language creates duped groups #2971

Closed
MSoeb opened this issue Nov 3, 2023 · 2 comments

Comments

@MSoeb
Copy link

MSoeb commented Nov 3, 2023

Description: If different languages are used in the OS client and in the import file, groups are incorrectly duplicated when importing participants.

Example: The client is set to German and the English term for delegates is used in the import file. This results in the Delegates group being created again. One with the German term and one with the English term. To make it worse, this will lead to both terms being displayed in German in the participant filter options.

Group listing before import:
Screenshot_20231103_111658

group listing after data import with different languages:
Screenshot_20231103_111615

Reproduction:
0. Create a meeting in gemran language.

  1. open a meeting in german language
  2. open participants
  3. open the three-dot-menu > import menu
  4. download the example file and import it. The file should contain the english terms for Delegierte, Mitarbeitende.
  5. open the participant menu > three-dot-menu > groups. Delegates and Staff should now be created.
  6. open participants again and check filter menu > groups. Two Delegierte groups should be available.

What should happen:
When importing groups, it is necessary to check whether a standard group exists and whether this can be referenced in the selected client language. If the client is set to German, no second group should be created during import when using the English term in the import file, instead the accounts should be correctly integrated into the existing Delegates group. The aim is to ensure that groups are not unnecessarily duplicated.

This behavior should also apply to the other standard groups.

Notes:

@MSoeb MSoeb added the bug label Nov 3, 2023
@MSoeb MSoeb added this to the 4.2 milestone Nov 3, 2023
@MSoeb MSoeb changed the title Participant import: importing standards groups in different language creates group dupes Participant import: importing standards groups in different language creates duped groups Nov 3, 2023
@Elblinator
Copy link
Member

We once decided that it should be allowed to create groups with similar names (Deli vs deli)
I would want to open the discussion of how different languages fit into this behaviour

@luisa-beerboom
Copy link
Member

Now that the backend participant import is integrated, the import won't create groups any more and will instead ignore groups that it can't find, while using the default group if all are invalid. This means that accidental group duplication in imports is now impossible and therefore this issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants