Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login loop after logout #2906

Closed
Elblinator opened this issue Oct 18, 2023 · 6 comments
Closed

Login loop after logout #2906

Elblinator opened this issue Oct 18, 2023 · 6 comments
Labels
Milestone

Comments

@Elblinator
Copy link
Member

Elblinator commented Oct 18, 2023

Current behaviour:
If you logged out and try to login again, then you are stuck in a loading loop for

Reproduction:

  1. Login as any person
  2. log out
  3. log in with the same account
  4. there is a spinning login button
  5. reload the page and you are logged in

Wanted behaviour:
The indefinitely long spinning time should be prevented

@bastianjoel
Copy link
Member

The error does not seem to be related to the login issue

@bastianjoel
Copy link
Member

This seems to be related to the operator not getting ready. There were already issues regarding this kind of issue (e.g. #1609, #1390).
After fixing that we might also want to add an integration test for this.

@bastianjoel bastianjoel changed the title Prevent Error in console Login loop after logout Oct 18, 2023
@bastianjoel
Copy link
Member

bastianjoel commented Oct 18, 2023

This seems to be a race condition within autoupdate-stream.ts.

On logout the client sends the following messages to the shared worker:

  1. Individual subscription closes
  2. Endpoint update
  3. Auth change

It seems that subscriptions do not get correctly closed if the set endpoint or auth change message (not exactly sure which one, maybe both) get sent before the close message was sent.
The results in a broken subscription that does not contain data within its stream.

@bastianjoel bastianjoel linked a pull request Oct 20, 2023 that will close this issue
@bastianjoel bastianjoel removed a link to a pull request Oct 24, 2023
@bastianjoel bastianjoel assigned rrenkert and unassigned bastianjoel Oct 24, 2023
@bastianjoel
Copy link
Member

I cannot replicate this anymore.

@Elblinator
Copy link
Member Author

I updated the Issue description

@Elblinator Elblinator added this to the 4.1 milestone Nov 1, 2023
@MSoeb
Copy link

MSoeb commented Nov 27, 2023

Problem is solved.

@MSoeb MSoeb closed this as completed Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants