Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Error messages in motion > multi select > set submitters #2566

Closed
Elblinator opened this issue Jul 27, 2023 · 1 comment · Fixed by #2846
Closed

Prevent Error messages in motion > multi select > set submitters #2566

Elblinator opened this issue Jul 27, 2023 · 1 comment · Fixed by #2846
Assignees
Milestone

Comments

@Elblinator
Copy link
Member

Description:
In motions (amendments) > multi select > set submitters: in some constellations errors are thrown if submitters are addded or removed, and the action of adding is not finished

How to recreate:
motions/amendments > multiselect > set submitters

  1. if a submitter is added who already is a submitter in one of the motions/amendments an error occurs.
  2. if a submitter is removed who is not a submitter of any of the motions/amendments an error occurs.

Wanted behaviour:

  1. if someone tries to add a user as a submitter who is already a submitter, the wanted state is already reached: no error should be thrown, the adding for the affected submitter and the affected motions/amendments should be skipped, and the rest should be finished
  2. if someone tries to remove a user as a submitter who is not a submitter, the wanted state is already reached: no error should be thrown, the removal for the affected submitter and the affected motions/amendments should be skipped, and the rest action should be finished
@Elblinator Elblinator added the bug label Jul 27, 2023
@Elblinator Elblinator added this to the 4.1 milestone Jul 27, 2023
@reiterl reiterl self-assigned this Oct 2, 2023
@reiterl
Copy link
Member

reiterl commented Oct 2, 2023

I found three possible problems:

  • empty actions leads to error
  • add a user which already is submitter leads to unique error
  • remove a user which is not a submitter leads to an missing error
    Also I needed to update the motions, so no longer old data is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants