New flags in motion.create_forwarded #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisa-beerboom
requested review from
r-peschke
and removed request for
r-peschke
This was referenced May 2, 2024
r-peschke
requested changes
May 6, 2024
r-peschke
reviewed
Jul 12, 2024
Then please reply to it. Usually, if I reply without changing the code, it is because I want further explanation. |
luisa-beerboom
assigned luisa-beerboom and r-peschke and unassigned r-peschke and luisa-beerboom
|
@r-peschke I've pretty much removed all of the locks on the datastore calls in the forwarding methods, as none of the data called is actually overwritten, since this is, in fact, a type of create function. |
|
Please fix failing tests. Except this one and the remark from @rrenkert (basing on feature/motion_forward) this is okay for me |
|
I'll dismiss @r-peschke CR adn merge this pr given that this PR stops work on the issue #2519 @r-peschke comment "this is okay for me" and that the feature is merged into it's own feature branch |
Elblinator
force-pushed
the
2382-enhance-create-forwarded
branch
from
2140cdd to
78cef3f
Compare
…382-enhance-create-forwarded
luisa-beerboom
merged commit 6c5ca92
into
OpenSlides:feature/motion-forward
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2382
Closes #2419
For now I handled the problem of "how to use original submitters if they aren't in the target meeting" by using the meeting_user in the other meeting (discussed this with @rrenkert)
If we're going to do this, we should see if there's strange bugs in the client.
Things like:
Removed
forwarding_user_idrelation from the committee, as it loses it's purpose beginning with this PR