Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation in OAA to continue instead of blocking it because of partitioning rules #236

Open
j-ode opened this issue Mar 6, 2023 · 0 comments

Comments

@j-ode
Copy link

j-ode commented Mar 6, 2023

For CaC disk partitioning rules that use anaconda remediation template from shared/templates/mount/anaconda.template, OAA uses MESSAGE_TYPE_FATAL if the partitioning is incorrect, which blocks the installation:

if self._mount_point not in mount_points:
msg = _("{0} must be on a separate partition or logical "
"volume and has to be created in the "
"partitioning layout before installation can occur "
"with a security profile").format(self._mount_point)
messages.append(RuleMessage(self.__class__,
common.MESSAGE_TYPE_FATAL, msg))

For my bachelor thesis, where I am creating a CaC profile for common fedora users, I would like to somehow alert them in OAA that they should partition their disk in a certain way, but I do not want to block the installation, because some users may not want to or know how to partition a disk, and the whole point of the profile is usability and simplicity. I know this can be automated with kickstart, but common users do not know what that is or how to use it, and I want no additional steps for users outside of anaconda.

Would it be possible to somehow allow OAA to use MESSAGE_TYPE_WARNING for partitioning rules, like here:

if self._require_password and not bootloader_proxy.IsPasswordSet:
# TODO: Anaconda provides a way to set bootloader password:
# bootloader_proxy.SetEncryptedPassword(...)
# We don't support setting the bootloader password yet,
# but we shouldn't stop the installation, just because of that.
return [RuleMessage(self.__class__, common.MESSAGE_TYPE_WARNING,
"boot loader password not set up")]
(where it states in the comment that it does not stop the installation)?

I imagine this being done either by detecting what profile is being used in OAA and adding an if, which would use MESSAGE_TYPE_WARNING if my common user profile is used. Another way could be to somehow indicate which type of behavior we prefer in the rule directly. I am not sure what would be more effective, or if there are some more obvious solutions.

This is in no way critical, it would just be nice to have :-)

@j-ode j-ode changed the title Add possibility to use MESSAGE_TYPE_WARNING instead of MESSAGE_TYPE_FATAL for partitioning rules Allow installation in OAA to continue instead of blocking it because of partitioning rules Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants