Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codeplug: longitude field in geo_t structure too small #30

Open
silseva opened this issue Oct 1, 2023 · 0 comments · May be fixed by #32
Open

Codeplug: longitude field in geo_t structure too small #30

silseva opened this issue Oct 1, 2023 · 0 comments · May be fixed by #32
Labels
errata Documentation error

Comments

@silseva
Copy link
Contributor

silseva commented Oct 1, 2023

As DM3MAT pointed out, the longitude field in the geo_t data structure is an int8_t and will overflow for values above +/- 127 degrees.
@silseva silseva added the errata Documentation error label Oct 1, 2023
silseva added a commit that referenced this issue Oct 7, 2023
@silseva
Partial reorganization of the CPS format.
12002ab 
Header:
- changed the magic field from 64 to 32 bit
- extented the version number from 16 to 32 bit

Channel:
- changed transmit power from dBm to mW, extending the field from 8 to 32 bit
- dropped the scan list index field
- dropped the group list index field
- changed the longitude field from 8 to 16 bit to fix #30
@silseva silseva linked a pull request Oct 7, 2023 that will close this issue
Open
silseva added a commit that referenced this issue Oct 8, 2023
@silseva
Partial reorganization of the codeplug format.
01a9c2c 
Header:
- changed the magic field from 64 to 32 bit
- extented the version number from 16 to 32 bit

Channel:
- changed transmit power from dBm to mW, extending the field from 8 to 32 bit
- dropped the scan list index field
- dropped the group list index field
- changed the longitude field from 8 to 16 bit to fix #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
errata Documentation error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RFC: partial reorganization of the CPS format. OpenRTX/openrtx.github.io
1 participant
@silseva