diff --git a/CHANGES.md b/CHANGES.md index 15977239ed..788ada7d8c 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -4,6 +4,8 @@ CHANGES - OpenPrinting CUPS 2.4.8 - TBA Changes in CUPS v2.4.8 (TBA) ---------------------------- +- Added additional check on socket if `revents` from `poll()` returns POLLHUP + together with POLLIN or POLLOUT in `httpAddrConnect2()` (Issue #839) - Added new value for 'lpstat' option '-W' - successfull - for getting successfully printed jobs (Issue #830) - Added warning if the device has to be asked for 'all,media-col-database' separately diff --git a/cups/http-addrlist.c b/cups/http-addrlist.c index 198d073d06..cffcf184c8 100644 --- a/cups/http-addrlist.c +++ b/cups/http-addrlist.c @@ -318,21 +318,38 @@ httpAddrConnect2( { # ifdef HAVE_POLL DEBUG_printf(("pfds[%d].revents=%x\n", i, pfds[i].revents)); -# ifdef __sun - // Solaris connect runs asynchronously returning EINPROGRESS. Following - // poll() does not detect the socket is not connected and returns - // POLLIN|POLLOUT. Check the connection status and update error flag. - int sres, serr; - socklen_t slen = sizeof(serr); - sres = getsockopt(fds[i], SOL_SOCKET, SO_ERROR, &serr, &slen); - if (sres || serr) + +# ifdef _WIN32 + if (((WSAGetLastError() == WSAEINPROGRESS) && (pfds[i].revents & POLLIN) && (pfds[i].revents & POLLOUT)) || + ((pfds[i].revents & POLLHUP) && (pfds[i].revents & (POLLIN|POLLOUT)))) +# else + if (((errno == EINPROGRESS) && (pfds[i].revents & POLLIN) && (pfds[i].revents & POLLOUT)) || + ((pfds[i].revents & POLLHUP) && (pfds[i].revents & (POLLIN|POLLOUT)))) +# endif /* _WIN32 */ { - pfds[i].revents |= POLLERR; -# ifdef DEBUG - DEBUG_printf(("1httpAddrConnect2: getsockopt returned: %d with error: %s", sres, strerror(serr))); -# endif + // Some systems generate POLLIN or POLLOUT together with POLLHUP when doing + // asynchronous connections. The solution seems to be to use getsockopt to + // check the SO_ERROR value and ignore the POLLHUP if there is no error or + // the error is EINPROGRESS. + + int sres, /* Return value from getsockopt() - 0, or -1 if error */ + serr; /* Option SO_ERROR value */ + socklen_t slen = sizeof(serr); /* Option value size */ + + sres = getsockopt(fds[i], SOL_SOCKET, SO_ERROR, &serr, &slen); + + if (sres || serr) + { + pfds[i].revents |= POLLERR; +# ifdef DEBUG + DEBUG_printf(("1httpAddrConnect2: getsockopt returned: %d with error: %s", sres, strerror(serr))); +# endif + } + else if (pfds[i].revents && (pfds[i].revents & POLLHUP) && (pfds[i].revents & (POLLIN | POLLOUT))) + { + pfds[i].revents &= ~POLLHUP; + } } -# endif // __sun if (pfds[i].revents && !(pfds[i].revents & (POLLERR | POLLHUP)))