From a7a689880108d89f6d3087a1e086d4d06912e3a8 Mon Sep 17 00:00:00 2001 From: Jelte Jansen Date: Mon, 18 Sep 2023 17:47:30 +0200 Subject: [PATCH 01/15] Make sure NL-R-007 only fires on invoices, not on creditnotes (UBL) NL-R-007 requires that a payment means is provided, which only makes sense if there is a payment, i.e. for positive invoices. --- rules/sch/PEPPOL-EN16931-UBL.sch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/sch/PEPPOL-EN16931-UBL.sch b/rules/sch/PEPPOL-EN16931-UBL.sch index bef742f5..34372a6f 100644 --- a/rules/sch/PEPPOL-EN16931-UBL.sch +++ b/rules/sch/PEPPOL-EN16931-UBL.sch @@ -635,7 +635,7 @@ Last update: 2023 May release 3.0.15. [NL-R-006] For suppliers in the Netherlands, if the fiscal representative is in the Netherlands, the representative's address (cac:TaxRepresentativeParty/cac:PostalAddress) MUST contain street name (cbc:StreetName), city (cbc:CityName) and post code (cbc:PostalZone) - + [NL-R-007] For suppliers in the Netherlands, the supplier MUST provide a means of payment (cac:PaymentMeans) if the payment is from customer to supplier From 5cc83d53e12c58385f9b43398d4c6693b8d742b2 Mon Sep 17 00:00:00 2001 From: Jelte Jansen Date: Mon, 18 Sep 2023 17:48:48 +0200 Subject: [PATCH 02/15] Make sure NL-R-007 only fires on invoices, not on creditnotes (CII) NL-R-007 requires that a payment means is provided, which only makes sense if there is a payment, i.e. for positive invoices (typecode != 381). --- rules/sch/PEPPOL-EN16931-CII.sch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/sch/PEPPOL-EN16931-CII.sch b/rules/sch/PEPPOL-EN16931-CII.sch index 3c855f7e..d7a8410f 100644 --- a/rules/sch/PEPPOL-EN16931-CII.sch +++ b/rules/sch/PEPPOL-EN16931-CII.sch @@ -482,7 +482,7 @@ Last update: 2022 May release 3.0.13. - [NL-R-007] For suppliers in the Netherlands, the supplier MUST provide a means of payment (ram:SpecifiedTradeSettlementPaymentMeans) if the payment is from customer to supplier + [NL-R-007] For suppliers in the Netherlands, the supplier MUST provide a means of payment (ram:SpecifiedTradeSettlementPaymentMeans) if the payment is from customer to supplier From 6c84f6e1fb15fb4deb45f34bde2cd326e8b08606 Mon Sep 17 00:00:00 2001 From: Jelte Jansen Date: Wed, 20 Sep 2023 14:46:05 +0200 Subject: [PATCH 03/15] Add test case for update to NL-R-007 to UBL unit tests --- rules/unit-UBL-NL/NL-R-007.xml | 177 ++++++++++++++++++++++++++++++++- 1 file changed, 173 insertions(+), 4 deletions(-) diff --git a/rules/unit-UBL-NL/NL-R-007.xml b/rules/unit-UBL-NL/NL-R-007.xml index 035676e4..66c8161b 100755 --- a/rules/unit-UBL-NL/NL-R-007.xml +++ b/rules/unit-UBL-NL/NL-R-007.xml @@ -1,10 +1,11 @@ - For suppliers in the Netherlands, the supplier MUST provide a means of payment (cac:PaymentMeans) if the payment is from customer to supplier + For suppliers in the Netherlands, the supplier MUST provide a means of payment (cac:PaymentMeans) if the payment is from customer to supplier NL-R-007 + NL-R-007 @@ -181,7 +182,6 @@ - 17409.09 @@ -287,6 +287,7 @@ + NL-R-007 @@ -454,7 +455,6 @@ - 17409.09 @@ -559,4 +559,173 @@ - + + + + NL-R-007 + + + 2.1 + urn:cen.eu:en16931:2017#compliant#urn:fdc:peppol.eu:2017:poacc:billing:3.0 + urn:fdc:peppol.eu:2017:poacc:billing:01:1.0 + 12115118 + 2015-01-09 + 381 + + Alle leveringen zijn franco. Alle prijzen zijn incl. BTW. Betalingstermijn: 14 dagen netto. Prijswijzigingen voorbehouden. Op al onze + aanbiedingen, leveringen en overeenkomsten zijn van toepassing in de algemene verkoop en leveringsvoorwaarden. Gedeponeerd bij de K.v.K. te + Amsterdam 25-04-'85##Delivery terms + + EUR + 47806 + + 47806 + + + + 46568 + + + + + SITEST00000 + + Simplerstraat 1 + InvoicingStad + 1111 ZZ + + NL + + + + NL1111.11.111.B.01 + + VAT + + + + SimplerInvoicing + SITEST00000 + + + + + + 11111111 + + 10202 + + + Teststraat 123 + Grotestad + 1111 AA + + NL + + + + Ontvanger + 11111111 + + + + + Credit note + + + 27.00 + + 100.00 + 21.00 + + S + 21 + + VAT + + + + + 100.00 + 6.00 + + S + 6 + + VAT + + + + + + 200.00 + 200.00 + 227.00 + 227.00 + + + 1 + 4 + 200.00 + + SimplerInvoicing test invoice + + 166022 + + + S + 21 + + VAT + + + + + 50.00 + + + + 2 + 1 + 100.00 + + Testing procedures + + 661813 + + + S + 6 + + VAT + + + + + 100.00 + + + + 3 + -1 + -100.00 + + Previous Test CreditNote returned + + 438146 + + + S + 21 + + VAT + + + + + 100.00 + + + + + \ No newline at end of file From e63340893cc03e3ff2cb81839a81c930c065a3c1 Mon Sep 17 00:00:00 2001 From: Jelte Jansen Date: Wed, 20 Sep 2023 14:49:19 +0200 Subject: [PATCH 04/15] Add test case for update to NL-R-007 to CII unit tests --- rules/unit-CII-NL/NL-R-007.xml | 251 +++++++++++++++++++++++++++------ 1 file changed, 208 insertions(+), 43 deletions(-) diff --git a/rules/unit-CII-NL/NL-R-007.xml b/rules/unit-CII-NL/NL-R-007.xml index 80aee1b4..46dfa9f6 100755 --- a/rules/unit-CII-NL/NL-R-007.xml +++ b/rules/unit-CII-NL/NL-R-007.xml @@ -1,21 +1,15 @@ - For suppliers in the Netherlands, the supplier MUST provide a means of payment (ram:SpecifiedTradeSettlementPaymentMeans) if the payment is from customer to supplier + For suppliers in the Netherlands, the supplier MUST provide a means of payment (ram:SpecifiedTradeSettlementPaymentMeans) if the payment is from customer to supplier NL-R-007 + NL-R-007 - - + urn:fdc:peppol.eu:2017:poacc:billing:01:1.0 @@ -24,7 +18,6 @@ urn:cen.eu:en16931:2017#compliant#urn:fdc:peppol.eu:2017:poacc:billing:3.0 - 12345 380 @@ -32,9 +25,7 @@ 20210101 - - 1 @@ -61,7 +52,6 @@ - 2 @@ -88,7 +78,6 @@ - 123_reference @@ -109,7 +98,6 @@ NL1111111111B01 - Buyers B.V. @@ -123,17 +111,14 @@ - Trade Party - 08/00355 SEK - 30 @@ -143,7 +128,6 @@ BANKSBIC - 63 VAT @@ -151,7 +135,6 @@ S 21 - false @@ -182,7 +165,6 @@ 21 - 20180307 @@ -199,21 +181,14 @@ - + NL-R-007 - - + urn:fdc:peppol.eu:2017:poacc:billing:01:1.0 @@ -222,7 +197,6 @@ urn:cen.eu:en16931:2017#compliant#urn:fdc:peppol.eu:2017:poacc:billing:3.0 - 12345 380 @@ -230,9 +204,7 @@ 20210101 - - 1 @@ -259,7 +231,6 @@ - 2 @@ -286,7 +257,6 @@ - 123_reference @@ -307,7 +277,6 @@ NL1111111111B01 - Buyers B.V. @@ -321,17 +290,14 @@ - Trade Party - 08/00355 SEK - 63 VAT @@ -339,7 +305,6 @@ S 21 - false @@ -370,7 +335,6 @@ 21 - 20180307 @@ -387,7 +351,208 @@ - - + + + + NL-R-007 + + + + + urn:fdc:peppol.eu:2017:poacc:billing:01:1.0 + + + urn:cen.eu:en16931:2017#compliant#urn:fdc:peppol.eu:2017:poacc:billing:3.0 + + + + 2018210 + 381 + + 20180208 + + + + + + 1 + + + Printing paper + + + + 1 + + + + 1000 + + + + VAT + S + 25 + + + 1000 + + + + + + 2 + + + Parker Pen + + + + 5 + + + + 100 + + + + VAT + S + 25 + + + 500 + + + + + + 3 + + + Eraser P-97 + + + + 5 + + + + 500 + + + + VAT + S + 12 + + + 2500 + + + + + Ref 123 + + Allsälj AB + + 12345678 + + + 1234AA + SellerStreet 1 + Commercity + NL + + + 12345678 + + + SE123456789001 + + + Godkänd för F-skatt + + + + Buyercompany ltd + + DK + + + 87654321 + + + + + + 08/00355 + SEK + + 375 + VAT + 1500 + S + 25 + + + 300 + VAT + 2500 + S + 12 + + + + false + + 10 + 0 + 0 + 95 + Loyal customer + + VAT + S + 25 + + + + + true + + 10 + 0 + 0 + ABL + Packaging + + VAT + S + 25 + + + + + 20180307 + + + + 4000 + 0 + 0 + 4000 + 675 + 4675 + 4675 + + + 12345 + + + + + + \ No newline at end of file From 7b5032fb2917ed5fc857877c8af6713e99eb3255 Mon Sep 17 00:00:00 2001 From: Jelte Jansen Date: Mon, 25 Sep 2023 14:39:17 +0200 Subject: [PATCH 05/15] Do make PaymentMeans mandatory for negative CreditNote (UBL) Addendum to the fix in a7a689880108d89f6d3087a1e086d4d06912e3a8, in case the CreditNote itself is negative, the payment means should be required. --- rules/sch/PEPPOL-EN16931-UBL.sch | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rules/sch/PEPPOL-EN16931-UBL.sch b/rules/sch/PEPPOL-EN16931-UBL.sch index 34372a6f..5b4be523 100644 --- a/rules/sch/PEPPOL-EN16931-UBL.sch +++ b/rules/sch/PEPPOL-EN16931-UBL.sch @@ -635,9 +635,9 @@ Last update: 2023 May release 3.0.15. [NL-R-006] For suppliers in the Netherlands, if the fiscal representative is in the Netherlands, the representative's address (cac:TaxRepresentativeParty/cac:PostalAddress) MUST contain street name (cbc:StreetName), city (cbc:CityName) and post code (cbc:PostalZone) - + - [NL-R-007] For suppliers in the Netherlands, the supplier MUST provide a means of payment (cac:PaymentMeans) if the payment is from customer to supplier + [NL-R-007] For suppliers in the Netherlands, the supplier MUST provide a means of payment (cac:PaymentMeans) if the payment is from customer to supplier From edc57436a028e4690a990041fbcd6c83888695a3 Mon Sep 17 00:00:00 2001 From: Jelte Jansen Date: Mon, 25 Sep 2023 16:01:47 +0200 Subject: [PATCH 06/15] Do make PaymentMeans mandatory for negative CreditNote (CII) Addendum to the fix in 5cc83d53e12c58385f9b43398d4c6693b8d742b2, in case the CreditNote itself is negative, the payment means should be required. --- rules/sch/PEPPOL-EN16931-CII.sch | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/rules/sch/PEPPOL-EN16931-CII.sch b/rules/sch/PEPPOL-EN16931-CII.sch index d7a8410f..003726a2 100644 --- a/rules/sch/PEPPOL-EN16931-CII.sch +++ b/rules/sch/PEPPOL-EN16931-CII.sch @@ -482,7 +482,11 @@ Last update: 2022 May release 3.0.13. - [NL-R-007] For suppliers in the Netherlands, the supplier MUST provide a means of payment (ram:SpecifiedTradeSettlementPaymentMeans) if the payment is from customer to supplier + [NL-R-007] For suppliers in the Netherlands, the supplier MUST provide a means of payment (ram:SpecifiedTradeSettlementPaymentMeans) if the payment is from customer to supplier From 8a1dae1f41a6b6c0faf4fb89b713aebc52bb26a3 Mon Sep 17 00:00:00 2001 From: Jelte Jansen Date: Mon, 25 Sep 2023 16:07:13 +0200 Subject: [PATCH 07/15] Testcase updates Add additional error cases for the fixes in commits 7b5032fb2917ed5fc857877c8af6713e99eb3255 and edc57436a028e4690a990041fbcd6c83888695a3 --- rules/unit-CII-NL/NL-R-007.xml | 202 +++++++++++++++++++++++++++++++++ rules/unit-UBL-NL/NL-R-007.xml | 169 +++++++++++++++++++++++++++ 2 files changed, 371 insertions(+) diff --git a/rules/unit-CII-NL/NL-R-007.xml b/rules/unit-CII-NL/NL-R-007.xml index 46dfa9f6..651e599a 100755 --- a/rules/unit-CII-NL/NL-R-007.xml +++ b/rules/unit-CII-NL/NL-R-007.xml @@ -555,4 +555,206 @@ + + + + NL-R-007 + + + + + urn:fdc:peppol.eu:2017:poacc:billing:01:1.0 + + + urn:cen.eu:en16931:2017#compliant#urn:fdc:peppol.eu:2017:poacc:billing:3.0 + + + + 2018210 + 381 + + 20180208 + + + + + + 1 + + + Printing paper + + + + 1 + + + + -1000 + + + + VAT + S + 25 + + + -1000 + + + + + + 2 + + + Parker Pen + + + + 5 + + + + -100 + + + + VAT + S + 25 + + + -500 + + + + + + 3 + + + Eraser P-97 + + + + 5 + + + + -500 + + + + VAT + S + 12 + + + -2500 + + + + + Ref 123 + + Allsälj AB + + 12345678 + + + 1234AA + SellerStreet 1 + Commercity + NL + + + 12345678 + + + SE123456789001 + + + Godkänd för F-skatt + + + + Buyercompany ltd + + DK + + + 87654321 + + + + + + 08/00355 + SEK + + -375 + VAT + -1500 + S + 25 + + + -300 + VAT + -2500 + S + 12 + + + + false + + 10 + 0 + 0 + 95 + Loyal customer + + VAT + S + 25 + + + + + true + + 10 + 0 + 0 + ABL + Packaging + + VAT + S + 25 + + + + + 20180307 + + + + -4000 + 0 + 0 + -4000 + -675 + -4675 + -4675 + + + 12345 + + + + + \ No newline at end of file diff --git a/rules/unit-UBL-NL/NL-R-007.xml b/rules/unit-UBL-NL/NL-R-007.xml index 66c8161b..f9704fb1 100755 --- a/rules/unit-UBL-NL/NL-R-007.xml +++ b/rules/unit-UBL-NL/NL-R-007.xml @@ -728,4 +728,173 @@ + + + + NL-R-007 + + + 2.1 + urn:cen.eu:en16931:2017#compliant#urn:fdc:peppol.eu:2017:poacc:billing:3.0 + urn:fdc:peppol.eu:2017:poacc:billing:01:1.0 + 12115118 + 2015-01-09 + 381 + + Alle leveringen zijn franco. Alle prijzen zijn incl. BTW. Betalingstermijn: 14 dagen netto. Prijswijzigingen voorbehouden. Op al onze + aanbiedingen, leveringen en overeenkomsten zijn van toepassing in de algemene verkoop en leveringsvoorwaarden. Gedeponeerd bij de K.v.K. te + Amsterdam 25-04-'85##Delivery terms + + EUR + 47806 + + 47806 + + + + 46568 + + + + + SITEST00000 + + Simplerstraat 1 + InvoicingStad + 1111 ZZ + + NL + + + + NL1111.11.111.B.01 + + VAT + + + + SimplerInvoicing + SITEST00000 + + + + + + 11111111 + + 10202 + + + Teststraat 123 + Grotestad + 1111 AA + + NL + + + + Ontvanger + 11111111 + + + + + Credit note + + + -27.00 + + -100.00 + -21.00 + + S + 21 + + VAT + + + + + -100.00 + -6.00 + + S + 6 + + VAT + + + + + + -200.00 + -200.00 + -227.00 + -227.00 + + + 1 + -4 + -200.00 + + SimplerInvoicing test invoice + + 166022 + + + S + 21 + + VAT + + + + + 50.00 + + + + 2 + -1 + -100.00 + + Testing procedures + + 661813 + + + S + 6 + + VAT + + + + + 100.00 + + + + 3 + 1 + 100.00 + + Previous Test CreditNote returned + + 438146 + + + S + 21 + + VAT + + + + + 100.00 + + + + \ No newline at end of file From f866cf4db60710cd1baa4f5491d7a269db981dbe Mon Sep 17 00:00:00 2001 From: Martin Forsberg Date: Fri, 9 Feb 2024 14:56:56 +0100 Subject: [PATCH 08/15] Prepared release (empty) notes for 2024 May release --- guide/release-notes/main.adoc | 2 ++ guide/release-notes/v3.0.17.adoc | 11 +++++++++++ 2 files changed, 13 insertions(+) create mode 100644 guide/release-notes/v3.0.17.adoc diff --git a/guide/release-notes/main.adoc b/guide/release-notes/main.adoc index 41d5e6cb..b61fa451 100644 --- a/guide/release-notes/main.adoc +++ b/guide/release-notes/main.adoc @@ -15,6 +15,8 @@ IMPORTANT: Changes in code lists are also reflected by changes in the validation :leveloffset: +1 +include::v3.0.17.adoc[] + include::v3.0.16.adoc[] include::v3.0.15.adoc[] diff --git a/guide/release-notes/v3.0.17.adoc b/guide/release-notes/v3.0.17.adoc new file mode 100644 index 00000000..7e38e4c5 --- /dev/null +++ b/guide/release-notes/v3.0.17.adoc @@ -0,0 +1,11 @@ += Version 3.0.17 +[horizontal] +Release date:: May 2024 + +== Changes to BIS document + + +== Changes to code lists and validation artefacts + + +== EN 16931 schematrons updated From d92a40b48c55fe7799f4dddbba5a6a7ffba9c00c Mon Sep 17 00:00:00 2001 From: Martin Forsberg Date: Fri, 9 Feb 2024 16:32:17 +0100 Subject: [PATCH 09/15] POACC-735 SE rule for check digit --- rules/sch/PEPPOL-EN16931-UBL.sch | 27 +- rules/unit-UBL-PEPPOL/PEPPOL-COMMON-R049.xml | 15 +- rules/unit-UBL-SE/UBL-IN_SE-R-013.xml | 311 +++++++++++++++++++ 3 files changed, 351 insertions(+), 2 deletions(-) create mode 100644 rules/unit-UBL-SE/UBL-IN_SE-R-013.xml diff --git a/rules/sch/PEPPOL-EN16931-UBL.sch b/rules/sch/PEPPOL-EN16931-UBL.sch index afb328cb..1749acad 100644 --- a/rules/sch/PEPPOL-EN16931-UBL.sch +++ b/rules/sch/PEPPOL-EN16931-UBL.sch @@ -196,6 +196,30 @@ Last update: 2023 May release 3.0.15. (number($digits[1])*256) "/> + + + + + + + + + + + + + + + + + + @@ -362,7 +386,7 @@ Last update: 2023 May release 3.0.15. Italian VAT Code (Partita Iva) must be stated in the correct format --> - Swedish organization number MUST be stated in the correct format. + Swedish organization number MUST be stated in the correct format. Australian Business Number (ABN) MUST be stated in the correct format. @@ -471,6 +495,7 @@ Last update: 2023 May release 3.0.15. Swedish organisation numbers should be numeric. Swedish organisation numbers consist of 10 characters. + The last digit of a Swedish organization number must be valid according to the Luhn algorithm. For Swedish suppliers, when using Seller tax registration identifier, 'Godkänd för F-skatt' must be stated diff --git a/rules/unit-UBL-PEPPOL/PEPPOL-COMMON-R049.xml b/rules/unit-UBL-PEPPOL/PEPPOL-COMMON-R049.xml index a3c6b8c3..189c8f74 100644 --- a/rules/unit-UBL-PEPPOL/PEPPOL-COMMON-R049.xml +++ b/rules/unit-UBL-PEPPOL/PEPPOL-COMMON-R049.xml @@ -13,7 +13,7 @@ - 5566221100 + 2021005489 @@ -46,4 +46,17 @@ + + + PEPPOL-COMMON-R049 + + + + + 2021005480 + + + + + diff --git a/rules/unit-UBL-SE/UBL-IN_SE-R-013.xml b/rules/unit-UBL-SE/UBL-IN_SE-R-013.xml new file mode 100644 index 00000000..d9d6e23b --- /dev/null +++ b/rules/unit-UBL-SE/UBL-IN_SE-R-013.xml @@ -0,0 +1,311 @@ + + + + The last digit of a Swedish organization number must be valid according to the Luhn algorithm. + SE-R-013 + + + + SE-R-013 + + + + urn:cen.eu:en16931:2017#compliant#urn:fdc:peppol.eu:2017:poacc:billing:3.0 + urn:fdc:peppol.eu:2017:poacc:billing:01:1.0 + 2018210 + 2018-02-08 + 2018-03-07 + 380 + Testfil för kontroll av svenska valideringsregler + SEK + BuyerRef 123 + + + + 2021005489 + + Storgatan 1 + Stockholm + 11122 + + SE + + + + Godkänd för F-skatt + + TAX + + + + SE123456789001 + + VAT + + + + Allsälj AB + 2021005489 + Säte: Stockholm + + + + + + + 2021005489 + + Kommunteknisk service + + + Lilla gränd 9 + Stockholm + 10203 + + SE + + + + Kommunens Tekniska Bolag AB + 2021005489 + + + + + + 30 + 08/00355 + + 1234567 + Account name + + 9999 + + + + + + false + Rabatt + 11 + + S + 25 + + VAT + + + + + true + Förvaring + 11 + + S + 25 + + VAT + + + + + + 25 + + 100 + 25 + + S + 25 + + VAT + + + + + + + 100 + 100 + 125 + + 11 + 11 + 125 + + + + 1 + 5 + 100 + + Utbytesstol + + S + 25 + + VAT + + + + + 20 + + + + + + + + + + SE-R-013 + + + urn:cen.eu:en16931:2017#compliant#urn:fdc:peppol.eu:2017:poacc:billing:3.0 + urn:fdc:peppol.eu:2017:poacc:billing:01:1.0 + 2018210 + 2018-02-08 + 2018-03-07 + 380 + Testfil för kontroll av svenska valideringsregler + SEK + BuyerRef 123 + + + + 2021005489 + + Storgatan 1 + Stockholm + 11122 + + SE + + + + SE123456789001 + + VAT + + + + Allsälj AB + 2021005480 + Säte: Stockholm + + + + + + + 2021005489 + + Kommunteknisk service + + + Lilla gränd 9 + Stockholm + 10203 + + SE + + + + Kommunens Tekniska Bolag AB + 1234512345 + + + + + + 30 + 08/00355 + + 1234567 + Account name + + 9999 + + + + + + false + Rabatt + 11 + + S + 25 + + VAT + + + + + true + Förvaring + 11 + + S + 25 + + VAT + + + + + + 25 + + 100 + 25 + + S + 25 + + VAT + + + + + + + 100 + 100 + 125 + + 11 + 11 + 125 + + + + 1 + 5 + 100 + + Utbytesstol + + S + 25 + + VAT + + + + + 20 + + + + + + + From 42735f26ebbb7b17bd695c9f9b60ae03cc52db3f Mon Sep 17 00:00:00 2001 From: Martin Forsberg Date: Fri, 9 Feb 2024 16:59:37 +0100 Subject: [PATCH 10/15] handlng of non-numeric value --- rules/sch/PEPPOL-EN16931-UBL.sch | 41 +++++++++++++++++--------------- 1 file changed, 22 insertions(+), 19 deletions(-) diff --git a/rules/sch/PEPPOL-EN16931-UBL.sch b/rules/sch/PEPPOL-EN16931-UBL.sch index 1749acad..59323803 100644 --- a/rules/sch/PEPPOL-EN16931-UBL.sch +++ b/rules/sch/PEPPOL-EN16931-UBL.sch @@ -200,25 +200,28 @@ Last update: 2023 May release 3.0.15. - - - - - - - - - - - - - + + + + + + + + + + + + + + + + From 6f0a412933c80fe325722d1145c145c716475361 Mon Sep 17 00:00:00 2001 From: Martin Forsberg Date: Fri, 9 Feb 2024 17:11:10 +0100 Subject: [PATCH 11/15] Added rule and test case for CII --- rules/sch/PEPPOL-EN16931-CII.sch | 31 +- rules/unit-CII-PEPPOL/PEPPOL-COMMON-R049.xml | 30 +- rules/unit-CII-SE/CII-IN_SE-R-013.xml | 494 +++++++++++++++++++ 3 files changed, 552 insertions(+), 3 deletions(-) create mode 100644 rules/unit-CII-SE/CII-IN_SE-R-013.xml diff --git a/rules/sch/PEPPOL-EN16931-CII.sch b/rules/sch/PEPPOL-EN16931-CII.sch index 515b276c..28c3f363 100644 --- a/rules/sch/PEPPOL-EN16931-CII.sch +++ b/rules/sch/PEPPOL-EN16931-CII.sch @@ -171,6 +171,34 @@ Last update: 2022 May release 3.0.13. ((string-to-codepoints(substring($val,11,1)) - 48) * 19)) mod 89 = 0 "/> + + + + + + + + + + + + + + + + + + + + + + Business process MUST be provided. @@ -304,7 +332,7 @@ Last update: 2022 May release 3.0.13. Italian VAT Code (Partita Iva) must be stated in the correct format - Swedish organization number MUST be stated in the correct format. + Swedish organization number MUST be stated in the correct format. Australian Business Number (ABN) MUST be stated in the correct format. @@ -417,6 +445,7 @@ Last update: 2022 May release 3.0.13. Swedish organisation numbers should be numeric. Swedish organisation numbers consist of 10 characters. + The last digit of a Swedish organization number must be valid according to the Luhn algorithm. For Swedish suppliers, when using Seller tax registration identifier, 'Godkänd för F-skatt' must be stated diff --git a/rules/unit-CII-PEPPOL/PEPPOL-COMMON-R049.xml b/rules/unit-CII-PEPPOL/PEPPOL-COMMON-R049.xml index 091a97c6..837bbe39 100644 --- a/rules/unit-CII-PEPPOL/PEPPOL-COMMON-R049.xml +++ b/rules/unit-CII-PEPPOL/PEPPOL-COMMON-R049.xml @@ -22,12 +22,12 @@ - 5544332211 + 2021005489 - 5544332211 + 2021005489 @@ -91,6 +91,32 @@ + + + PEPPOL-COMMON-R049 + + + + + + 380 + + + + + + 2021005480 + + + + + + + diff --git a/rules/unit-CII-SE/CII-IN_SE-R-013.xml b/rules/unit-CII-SE/CII-IN_SE-R-013.xml new file mode 100644 index 00000000..ec76bdec --- /dev/null +++ b/rules/unit-CII-SE/CII-IN_SE-R-013.xml @@ -0,0 +1,494 @@ + + + + The last digit of a Swedish organization number must be valid according to the Luhn algorithm. + SE-R-013 + + + + SE-R-013 + + + + + + + urn:fdc:peppol.eu:2017:poacc:billing:01:1.0 + + + urn:cen.eu:en16931:2017#compliant#urn:fdc:peppol.eu:2017:poacc:billing:3.0 + + + + + 2018210 + 380 + + 20180208 + + + + + + + + 1 + + + Printing paper + + + + 1 + + + + 1000 + + + + VAT + S + 25 + + + 1000 + + + + + + + 2 + + + Parker Pen + + + + 5 + + + + 100 + + + + VAT + S + 25 + + + 500 + + + + + + + 3 + + + Eraser P-97 + + + + 5 + + + + 500 + + + + VAT + S + 12 + + + 2500 + + + + + + Ref 123 + + Allsälj AB + + 2021005489 + + + SE + + + 2021005489 + + + SE123456789001 + + + Godkänd för F-skatt + + + + + Buyercompany ltd + + DK + + + 2021005489 + + + + + + + + 08/00355 + SEK + + + 30 + + 123456 + + + BANKSBIC + + + + 30 + + 1234567 + + + SE:BANKGIRO + + + + 30 + + 12345678 + + + SE:PLUSGIRO + + + + + 375 + VAT + 1500 + S + 25 + + + 300 + VAT + 2500 + S + 12 + + + + + false + + 10 + 0 + 0 + 95 + Loyal customer + + VAT + S + 25 + + + + + true + + 10 + 0 + 0 + ABL + Packaging + + VAT + S + 25 + + + + + + 20180307 + + + + 4000 + 0 + 0 + 4000 + 675 + 4675 + 4675 + + + + + + + + + + SE-R-004 + + + + + + urn:fdc:peppol.eu:2017:poacc:billing:01:1.0 + + + urn:cen.eu:en16931:2017#compliant#urn:fdc:peppol.eu:2017:poacc:billing:3.0 + + + + + 2018210 + 380 + + 20180208 + + + + + + + + 1 + + + Printing paper + + + + 1 + + + + 1000 + + + + VAT + S + 25 + + + 1000 + + + + + + + 2 + + + Parker Pen + + + + 5 + + + + 100 + + + + VAT + S + 25 + + + 500 + + + + + + + 3 + + + Eraser P-97 + + + + 5 + + + + 500 + + + + VAT + S + 12 + + + 2500 + + + + + + Ref 123 + + Allsälj AB + + 2021005480 + + + SE + + + 2021005489 + + + SE123456789001 + + + + + Buyercompany ltd + + DK + + + 2021005489 + + + + + + + + 08/00355 + SEK + + + 30 + + 123456 + + + BANKSBIC + + + + 30 + + 1234567 + + + SE:BANKGIRO + + + + 30 + + 12345 + + + SE:PLUSGIRO + + + + + 375 + VAT + 1500 + S + 25 + + + 300 + VAT + 2500 + S + 12 + + + + + false + + 10 + 0 + 0 + 95 + Loyal customer + + VAT + S + 25 + + + + + true + + 10 + 0 + 0 + ABL + Packaging + + VAT + S + 25 + + + + + + 20180307 + + + + 4000 + 0 + 0 + 4000 + 675 + 4675 + 4675 + + + + + + + + + From 539fc6257378347d49b2ea627b646c2a163f7975 Mon Sep 17 00:00:00 2001 From: Martin Forsberg Date: Sun, 11 Feb 2024 10:42:08 +0100 Subject: [PATCH 12/15] Added rule reference and updated release notes --- guide/release-notes/v3.0.17.adoc | 1 + structure/syntax/part/supplier-party.xml | 1 + 2 files changed, 2 insertions(+) diff --git a/guide/release-notes/v3.0.17.adoc b/guide/release-notes/v3.0.17.adoc index 7e38e4c5..1706ca88 100644 --- a/guide/release-notes/v3.0.17.adoc +++ b/guide/release-notes/v3.0.17.adoc @@ -7,5 +7,6 @@ Release date:: May 2024 == Changes to code lists and validation artefacts +* Added new Swedish rule (SE-R-013) for validation of the check number of a Swedish Organization number. The rule is introduced as severity warning. All rules which verifies the format of Organization numbers (SE-R-003, SE-R-004 and SE-R-013) will be changed to severity fatal in next release. == EN 16931 schematrons updated diff --git a/structure/syntax/part/supplier-party.xml b/structure/syntax/part/supplier-party.xml index 2412656c..793e4157 100644 --- a/structure/syntax/part/supplier-party.xml +++ b/structure/syntax/part/supplier-party.xml @@ -300,6 +300,7 @@ DK-R-014 SE-R-003 SE-R-004 + SE-R-013 schemeID Seller legal registration identifier identification scheme identifier From b174290cbe644a4523cc1251d2660fd2d7b7f5c8 Mon Sep 17 00:00:00 2001 From: Martin Forsberg Date: Thu, 21 Mar 2024 10:44:35 +0100 Subject: [PATCH 13/15] POACC-735, missed one thing in the release notes --- guide/release-notes/v3.0.17.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/guide/release-notes/v3.0.17.adoc b/guide/release-notes/v3.0.17.adoc index 1706ca88..65d2fdb3 100644 --- a/guide/release-notes/v3.0.17.adoc +++ b/guide/release-notes/v3.0.17.adoc @@ -9,4 +9,6 @@ Release date:: May 2024 * Added new Swedish rule (SE-R-013) for validation of the check number of a Swedish Organization number. The rule is introduced as severity warning. All rules which verifies the format of Organization numbers (SE-R-003, SE-R-004 and SE-R-013) will be changed to severity fatal in next release. +* Update of PEPPOL-COMMON-R049 which validates identifiers using ICD/EAS 0007. The change is adding validation of the check number of a Swedish Organization number. + == EN 16931 schematrons updated From 3c9ecda2c7d7f4f324b921e2fb48fcff3d946f2a Mon Sep 17 00:00:00 2001 From: Jerry Dimitriou Date: Mon, 1 Apr 2024 15:18:27 +0300 Subject: [PATCH 14/15] Update v3.0.17.adoc --- guide/release-notes/v3.0.17.adoc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/guide/release-notes/v3.0.17.adoc b/guide/release-notes/v3.0.17.adoc index 65d2fdb3..3a32df9b 100644 --- a/guide/release-notes/v3.0.17.adoc +++ b/guide/release-notes/v3.0.17.adoc @@ -7,8 +7,10 @@ Release date:: May 2024 == Changes to code lists and validation artefacts -* Added new Swedish rule (SE-R-013) for validation of the check number of a Swedish Organization number. The rule is introduced as severity warning. All rules which verifies the format of Organization numbers (SE-R-003, SE-R-004 and SE-R-013) will be changed to severity fatal in next release. +* Added new Swedish rule (SE-R-013) for validation of the check number of a Swedish Organization number. The rule is introduced as severity warning. All rules which verify the format of Organization numbers (SE-R-003, SE-R-004 and SE-R-013) will be changed to severity fatal in the next release. -* Update of PEPPOL-COMMON-R049 which validates identifiers using ICD/EAS 0007. The change is adding validation of the check number of a Swedish Organization number. +* Update for rule NL-R-007 (mandatory payment means), the check should not fire if the document is a credit note with a positive amount. + +* Update of PEPPOL-COMMON-R049, which validates identifiers using ICD/EAS 0007. The change is adding validation of the check number of a Swedish Organization number. == EN 16931 schematrons updated From 26bb6ffb6b6febf15e14ddbf0a5070ce08687e75 Mon Sep 17 00:00:00 2001 From: Jerry Dimitriou Date: Tue, 2 Apr 2024 13:49:48 +0300 Subject: [PATCH 15/15] Update project.xml --- project.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/project.xml b/project.xml index 50696e79..89b0a194 100644 --- a/project.xml +++ b/project.xml @@ -1,7 +1,7 @@ - Peppol BIS Billing 3.0 - November 2023 Release + Peppol BIS Billing 3.0 - May 2024 Release - Member Review Business Interoperability Specifications (BIS) BIS compliance