Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support packed Jar files #10

Open
jesse-gallagher opened this issue Dec 26, 2019 · 1 comment
Open

Support packed Jar files #10

jesse-gallagher opened this issue Dec 26, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@jesse-gallagher
Copy link
Member

p2 repositories like Eclipse's include versions of the Jar files in .pack.gz format, and it's possible that there could be p2 repositories that have only these files.

This also raises the secondary question of discovery when present - oddly, these bundles seem to show up twice. e.g.:

    <artifact classifier='osgi.bundle' id='org.eclipse.emf.codegen.ecore.xtext' version='1.4.0.v20180706-1146'>
      <processing size='1'>
        <step id='org.eclipse.equinox.p2.processing.Pack200Unpacker' required='true'/>
      </processing>
      <properties size='9'>
        <property name='artifact.size' value='8988'/>
        <property name='download.size' value='8988'/>
        <property name='format' value='packed'/>
        <property name='maven-version' value='1.4.0-SNAPSHOT'/>
        <property name='maven-artifactId' value='org.eclipse.emf.codegen.ecore.xtext'/>
        <property name='maven-extension' value='jar.pack.gz'/>
        <property name='maven-groupId' value='org.eclipse.emf'/>
        <property name='maven-classifier' value='pack200'/>
        <property name='download.md5' value='bbb1d14e60febc44fd4982dfd4bd3e31'/>
      </properties>
    </artifact>

And:

    <artifact classifier='osgi.bundle' id='org.eclipse.emf.codegen.ecore.xtext' version='1.4.0.v20180706-1146'>
      <properties size='10'>
        <property name='artifact.size' value='13975'/>
        <property name='download.size' value='13975'/>
        <property name='download.md5' value='9ce335bad3569aaa73f48aef3dff24dc'/>
        <property name='download.checksum.md5' value='9ce335bad3569aaa73f48aef3dff24dc'/>
        <property name='download.checksum.sha-256' value='da049c8ead3c4be0f299f0eba1b14fef4f2d15a2f8208a4b8827ccf76349add1'/>
        <property name='maven-version' value='1.4.0-SNAPSHOT'/>
        <property name='maven-artifactId' value='org.eclipse.emf.codegen.ecore.xtext'/>
        <property name='maven-extension' value='jar.pack.gz'/>
        <property name='maven-groupId' value='org.eclipse.emf'/>
        <property name='maven-classifier' value='pack200'/>
      </properties>
    </artifact>
@jesse-gallagher jesse-gallagher added the enhancement New feature or request label Dec 26, 2019
@jesse-gallagher
Copy link
Member Author

Based on the size, the former represents the .jar.pack.gz and the latter represents the .jar. I'm not sure how one is supposed to know that the latter is just a .jar, but my best guess is that "true" p2 resolvers know that the <processing/> element indicates the presence of the .pack.gz extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant