Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate ways to improve the compilation environment on macOS #266

Open
jesse-gallagher opened this issue Apr 20, 2021 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@jesse-gallagher
Copy link
Member

Currently, AbstractEquinoxTask copies tools.jar from the current JVM into the Notes bundle in order to have a working compilation environment. This has never been great, but it's particularly problematic when compiling with Java versions >8, which don't have a tools.jar as such.

It may be better to do similar to what the Open Liberty Runtime does and download an AdoptOpenJDK build of Java 8 as needed and use that, copying in the Notes.jar and websvc.jar from Notes.app or referencing them in the launch classpath. That'd be cumbersome, but it should be reliable at least until the AdoptOpenJDK URLs change (which they may with the move to Adoptium).

@jesse-gallagher jesse-gallagher added the enhancement New feature or request label Apr 20, 2021
@jesse-gallagher
Copy link
Member Author

I investigated using the JDT by way of EclipseCompiler, but it looks like it is limited to working with filesystem-bound dependencies. There was a bug from way back about similar things, but that may have just been about compiling in-memory files (which works) and not about dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant