Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TLM references and prepare for future system structure refactoring #1339

Merged
merged 20 commits into from
Nov 8, 2024

Conversation

lochel
Copy link
Member

@lochel lochel commented Nov 7, 2024

This PR begins the transition to OMSimulator 3.0 as part of the dev/v3.0 branch. Key changes include:

  1. Removal of TLM Components: All TLM-related code has been removed to simplify the codebase and prepare for the integration of FMI 3.0 features.

  2. Unified System Structure (in progress): Next, I'll focus on consolidating the system structure by removing Weakly Connected (WC) and Strongly Connected (SC) system types. This will result in a single “System” structure with dynamic partitioning based on solver settings for each FMU.

Given the extent of these updates, this PR will involve substantial changes to the core architecture and API.

@lochel lochel linked an issue Nov 7, 2024 that may be closed by this pull request
@arun3688 arun3688 added the CI/Update Submodules Allow a pull request to update submodules label Nov 7, 2024
@lochel lochel added the project/openscaling OpenSCALING related issues and pull requests label Nov 8, 2024
@lochel
Copy link
Member Author

lochel commented Nov 8, 2024

The only remaining reference to TLM is now in OMEdit.rst. However, I am uncertain how to modify this file, as the entire OMEdit integration will be impacted bu the coming api changes. This is something we'll need to update later, once the api is stable.

For now, I will limit the scope of this pull request to removing all TLM remnants. The refactoring of the system structure will be handled in a separate pull request to keep the changes manageable.

@lochel lochel changed the title Begin OMSimulator 3.0 Development: Remove TLM and Refactor System Structure Remove TLM references and prepare for future system structure refactoring Nov 8, 2024
@lochel lochel self-assigned this Nov 8, 2024
@lochel lochel requested a review from arun3688 November 8, 2024 11:33
Copy link
Contributor

@arun3688 arun3688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@lochel lochel merged commit 10a23e5 into OpenModelica:dev/v3.0 Nov 8, 2024
2 checks passed
@lochel lochel deleted the dev/v3.0 branch November 8, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/Update Submodules Allow a pull request to update submodules project/openscaling OpenSCALING related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OMSimulator internal error
2 participants