Change Attribute Set

[Danieleeffe1]

I would like to point out this interesting plugin for Magento 1.

For those who don't already know it, it is a plug-in that allows the migration of a product from one set of attributes to another.

https://github.com/flagbit/Magento-ChangeAttributeSet

do you think it could be something useful to integrate into OpenMage?

[addison74]

The Magento team has not provided the feature to change the attribute set of a product for good reasons. However, there are cases when it would be useful. for example, we have products that did not yet have a well-established set of attributes. We started with a set of skeleton attributes, later the set of attributes was changed directly in the database as number.

I personally agree with an OpenMage to which extensions/modules can be added than one in which changes are constantly injected. It is easier to manage, if there are problems those extensions can be easily deactivated until they are solved. For example this PR #3451, which already has 120 conversations and 99 commits, it should have been adopted as an extension and not directly in OpenMage.

I tested the Flagbit extension a long time ago and found no problems. Changing a set of attributes must be done with caution because orphaned values may remain in the database. Here it depends on how you take it, it can be beneficial if you come back or not if the change is permanent. It is preferable, as I said, to make the change if the initial set of attributes is contained in the final set of attributes.

There is an extension that deletes orphaned attribute values for a product, but I have never used it.

https://github.com/magento-hackathon/EAVCleaner
https://gist.github.com/dfelton/042e15a51b9795b25cad0235a1bf9122

[fballiano]

I think it depends on the feature, some should be in the core (advanced grids) some not (like my extension), this is my opinion, depends on the domain.

about my extension. I'll check if the cache thing, if you have more info please tell me.

[sreichel]

I think the improvement to grids are to big for adding to core "in time".

EnhancedGrid extension was great. I would highly appreciate a fork and continue work on it.

[empiricompany]

Meanwhile I added it here, @fballiano please check this PR:
fballiano/awesome-openmage#1
PS: I think we should create an official awesome-openmage, or better put all in our website

[fballiano]

@empiricompany check the new version of the imagecleaner if it solves your issue

[fballiano]

@empiricompany the repo is in my name because to make it official we need an RFC, I started OpenMage/rfcs#9 but at the moment it went nowhere.

[addison74]

Maybe an RFC should be created to discuss some aspects such as what can be included in the OpenMage core and what not, when to create a PR and when an extension.

I remain of the opinion that any PR that is proposed must be as easy to follow as possible, an aspect that makes it easier to adopt. The more complex it is, the more facilities, the more interest in it will be lost over time and only a few people will have the patience to go through it.

[empiricompany]

I agree, the choice of what to include in the core is wide-ranging and depends on each individual's philosophy, which, as already explained, can be more conservative or more forward-thinking. Therefore, we should first understand what the future of the OpenMage project will be: whether it will involve in the development of new features while maintaining backward compatibility as much as possible, as originally planned, or if it will focus on long-term support by providing security patches, bug fixes, etc.
Let's discuss it openly, everyone should voice their opinion!