Spectramerger sprint #426
Merged
Spectramerger sprint #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Parameter Handling section
JeeH-K
requested changes
Dec 12, 2023
|
Thanks! I think besides the adding a few comments it is good to go. |
|
Addressed all comments! Done! |
|
There seems to be some linting errors/warnings: |
|
if you click on details you get the warings: |
OOPs, I will check them in no time! |
|
Bugs fixed! |
|
Thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added SpectraMerger section with a few examples. Also touched Parameter handling part a bit by providing a simple function to print out the full set of parameters with descriptions.