[NKV-SDK-Host] Refactor nkv host code #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ramachaitanyak
commented
Aug 20, 2024
ramachaitanyak
commented
ramachaitanyak
requested review from
somnathr and
velomatt
and removed request for
a team
somnathr
reviewed
Aug 20, 2024
somnathr
reviewed
Aug 20, 2024
host/src/nkv_framework.cpp
Outdated
| // This delete is not required with the STL container, clean up happens | ||
| // when container goes out of scope | ||
| //delete[] listing_keys; | ||
| //delete[] data_cache; |
There was a problem hiding this comment.
Please remove commented code
There was a problem hiding this comment.
Fixed or updated appropriately
benixon
reviewed
Aug 20, 2024
ramachaitanyak
force-pushed
the
nkv_test_cli_refactor
branch
from
19f0e9c to
66facb0
Compare
Brief Changes:
==============
* Fixed issue using resize and pushback at the same time
* Fix listing_keys and data_cache proto-types
* Gitlab upgrade, trigger:include now takes a string or list
* Fix Sonar-Scanner download.
- Get sonar-scanner from URL determined by CI/CD var
- Determine sonar-scanner dir name by listing contents of zip
Testing Done:
=============
* Run with gitlab pipeline
Signed-off-by: r.kavuluru <[email protected]>
ramachaitanyak
force-pushed
the
nkv_test_cli_refactor
branch
from
66facb0 to
13a70e8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.