Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Windows, when Eclipse IDE is closed, server JVM started via dev mode dashboard is left running #159

Closed
scottkurz opened this issue Sep 10, 2022 · 4 comments
Closed

On Windows, when Eclipse IDE is closed, server JVM started via dev mode dashboard is left running #159

scottkurz opened this issue Sep 10, 2022 · 4 comments
Labels
bug Something isn't working with the product high priority should-fix
Milestone
23.0.6

Comments

@scottkurz
Copy link
Member

When the Eclipse IDE is closed after a server was started using the dashboard, the JVM running mvn liberty:dev is shut down, however the Liberty server JVM is left running.

It looks like there is a ShutdownHook within the dev mode ci.common/ci.maven projects so not sure why this isn't doing the job.
@scottkurz scottkurz added this to the EOY 2022 GA milestone Sep 10, 2022
@scottkurz scottkurz added the bug Something isn't working with the product label Oct 24, 2022
@awisniew90
Copy link
Contributor

Cannot recreate on Mac. When Eclipse is closed with a Liberty server still up and running, the server is stopped and the process is no longer running.

@scottkurz
Copy link
Member Author

Confirmed in debugger that, in Win10, doing a clean exit of Eclipse does NOT result in the LMP ShutdownHook getting control. This ShutdownHook is what stops the Liberty server JVM in the case of a Ctrl+C. Thinking we have to clean up in LibertyDevPlugin.stop(BundleContext).

Curious though what happens on Mac. Does the ShutdownHook actually get control or does..something else clean it up???

@scottkurz
Copy link
Member Author

Officially giving up on this for this milestone.

I think we need to try to do a server stop. A server kill is disruptive, leading to unexpected issues like OpenLiberty/ci.maven#1536.

We should code up a server stop and then work with the LMP/LGP teams to see if it's OK to leave it at that or if we also need to do the rest of the cleanup in ci.common DevUtil.

@scottkurz scottkurz removed this from the EOY 2022 GA milestone Dec 9, 2022
@scottkurz scottkurz mentioned this issue Dec 9, 2022
Closed
@scottkurz scottkurz added this to the 1Q23 update milestone Jan 17, 2023
@scottkurz scottkurz changed the title When Eclipse IDE is closed, server JVM started via dev mode dashboard is left running On Windows, when Eclipse IDE is closed, server JVM started via dev mode dashboard is left running Jan 17, 2023
@scottkurz
Copy link
Member Author

Fixed by #322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working with the product high priority should-fix
Projects
None yet
Milestone
23.0.6
Development

No branches or pull requests
2 participants
@scottkurz @awisniew90