Call generate features on compile dependency changes in dev mode flow #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow-up issue opened for the scenario where generate-features runs twice on build file change for multi module projects: #1456 |
Signed-off-by: Kathryn Kodama <[email protected]>
Signed-off-by: Kathryn Kodama <[email protected]>
kathrynkodama
force-pushed
the
1441-build-file
branch
from
84d08ee
to
2cd21a3
Compare
turkeylurkey
approved these changes
Mar 21, 2022
TrevCraw
approved these changes
Mar 22, 2022
| if (redeployCheck) { | ||
| // update upstream Maven projects list | ||
| int index = upstreamMavenProjects.indexOf(backupUpstreamProject); | ||
| upstreamMavenProjects.set(index, upstreamProject); | ||
|
|
||
| List<Dependency> deps = upstreamProject.getDependencies(); | ||
| List<Dependency> oldDeps = backupUpstreamProject.getDependencies(); | ||
| if (!dependencyListsEquals(deps,oldDeps)) { | ||
| if (!dependencyListsEquals(deps, oldDeps)) { |
There was a problem hiding this comment.
Is there a reason why we need to have this check before the next check comparing only compilation dependencies?
There was a problem hiding this comment.
Good point, I have removed this check.
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/GenerateFeaturesMojo.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kathryn Kodama <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1441
Call
liberty:generate-featuresgoal when compile dependencies have changed in a build file, covers single module and multi module scenarios.Integration tests will be added as part of #1395
See OpenLiberty/ci.common#349