Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fhir adaptor gen: code assist issues in lightning #844

Closed
josephjclark opened this issue Nov 29, 2024 · 2 comments · Fixed by #849
Closed

Fhir adaptor gen: code assist issues in lightning #844

josephjclark opened this issue Nov 29, 2024 · 2 comments · Fixed by #849

Comments

@josephjclark
Copy link
Collaborator

josephjclark commented Nov 29, 2024

Two possible problems with code assist in lightning

  • DONE fhir-fr doesn't seem to type the builders object properly, so I get no code complete. Not running locally anyway.

  • And I've noticed that fhir-ndr-et doesn't seem to provide code assist for resources with multiple profiles. Strange because VSC manages to work it out 🤔

@github-project-automation github-project-automation bot moved this to New Issues in v2 Nov 29, 2024
@josephjclark josephjclark mentioned this issue Nov 29, 2024
7 tasks
@josephjclark
Copy link
Collaborator Author

Yeah so for anything with multiple profiles, in Lightning we can't load the definitions

In VSC, if I create a a new project and add the adaptor to it, this works fine:

import { builders } from "@openfn/language-fhir-fr";

builders.patient("fr-core-patient", {
   // I get full code assist here
});

Does that imply it's a monaco bug? Because we know the types are going in. It's just not tracking the dynamic type on the object.

@josephjclark josephjclark mentioned this issue Nov 30, 2024
6 tasks
@github-project-automation github-project-automation bot moved this from New Issues to Done in v2 Nov 30, 2024
@josephjclark
Copy link
Collaborator Author

This is now fixed in the generator but will need retro-fitting to fhir-ndr-et see #843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant