Add shapes to groups in legend for plotIndividualTimeProfile

[Felixmil]

Originally from Open-Systems-Pharmacology/OSPSuite-R#1206 in OSPSR:

manyObsDC <- readRDS(getTestDataFilePath("manyObsDC"))
manyObsDC$removeGroupAssignment(names = "Vergin 1995.Iv")

dataSet3 <- DataSet$new(name = "Data set 3")
dataSet3$setValues(xValues = 1, yValues = 1, yErrorValues = 1)
dataSet4 <- DataSet$new(name = "Data set 4")
dataSet4$setValues(xValues = 1, yValues = 1, yErrorValues = 1)

manyObsDC$addDataSets(c(dataSet3, dataSet4))

plotIndividualTimeProfile(manyObsDC)

yields:

The code responsible for this is in plot-individual-time-profile.R.

  profilePlot <- tlf::plotTimeProfile(
    data = simData,
    dataMapping = simulatedDataMapping,
    observedData = obsData,
    observedDataMapping = observedDataMapping,
    plotConfiguration = timeProfilePlotConfiguration
  )

  # Suppress certain mappings in the legend
  profilePlot <- profilePlot + ggplot2::guides(linetype = "none", shape = "none")

the {tlf} call yields:

the tlf output already have "wrong legend symbols" so the changes need to be made inside {tlf}.

[Felixmil]

@pchelle We need help with this. I think the part of the code responsible for that is this:

TLF-Library/R/plot-timeprofile.R

Line 361 in 5453524

updateTimeProfileLegend <- function(plotObject, caption) {

More info / examples here: Open-Systems-Pharmacology/OSPSuite-R#1206

[pchelle]

The function aimed at

• providing the appropriate color, fill, shape and linetype values to the ggplot2::scale_ functions
• display the corresponding legend using ggplot2::guides with option to override aesthetics

One of the issues here is that the scales and legend order are based on factor levels.
Partially shared groupings in the DataMapping can be responsible for the messed up legend.
Also, if the data uses characters, the factor levels use alphabetical order, the function also aimed at re-ordering if users wanted the legend order to be changed.

[pchelle]

We may need to rethink this whole function and the caption object so that the mapping can handle all the situations presented in the examples.