Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve network check in update_networking.sh #1317

Open
schmurtzm opened this issue Dec 11, 2023 · 1 comment · May be fixed by #1583
Open

Improve network check in update_networking.sh #1317

schmurtzm opened this issue Dec 11, 2023 · 1 comment · May be fixed by #1583
Assignees
Milestone

Comments

@schmurtzm
Copy link
Member

The current implementation use a ping to check the connectivity. It's better to make a check on http port as it is what we need next to use the time API.
OTA script can be a source of inspiration for that if the execution speed is correct.
It would be great to find a target website accessible from everywhere (may be worldtimeapi.org ).

It worth to check where we use ping commands at the same time as ICMP can be blocked on some user internet connections.

@schmurtzm schmurtzm converted this from a draft issue Dec 11, 2023
@schmurtzm schmurtzm added this to the v4.3 milestone Dec 11, 2023
@schmurtzm schmurtzm moved this from 📋 Backlog / To do to 🆕 New / To discuss in Onion Development Dec 15, 2023
@schmurtzm schmurtzm removed the status in Onion Development Dec 15, 2023
@schmurtzm schmurtzm modified the milestones: v4.3, v4.4 Mar 12, 2024
@XK9274 XK9274 linked a pull request May 13, 2024 that will close this issue
@XK9274 XK9274 linked a pull request May 13, 2024 that will close this issue
@XK9274
Copy link
Member

XK9274 commented May 13, 2024

Can you check over & make any changes you feel necessary: #1583

This is a multi-use script, you'll probably be more interested in the cmdline side of it.

@XK9274 XK9274 moved this to 🏗 In progress in Onion Development May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

2 participants