-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScummVM Standalone doesn't support all CD audio formats #1519
Comments
Hi, Can you try this build please: https://www.dropbox.com/scl/fi/1wd9ygx5mmv6scv54f0ch/scummvm.7z?rlkey=kwlf5do1ou9rf4t91lcuc92d7&dl=0 If you have issues, remove your config file and let it regen (in Saves/CurrentProfile) I've added:FLAC I see no options for m4a, though FAAD should do it no? If there's other options that need enabling please do comment and we'll see what we can do about expanding ScummVM Just~ FYI - GIF is compiled but does not get picked up, i'll check this another day. And compiled with This is a synced fork of scummvm so should be up to date with the master branch. If you find bugs please let us know - If not i'll move to PR. As for your other issue here: #1510 - I'm not getting into the dependency hole that is FluidSynth and Glib2 atm Other@Leemann07 - Please can you check if the missing commits are in this build from our previous conversations? Compile log
|
Alright the new link is above, sorry about that - had to recompile. |
Thanks so much for taking the time to make this new build. I just tested with all four audio formats, and all four are now working. flac, ogg, m4a, and mp3 all play CD audio with no error messages. re: As far as this issue is concerned, I'd consider it done and closeable. Thank you! |
More than happy to recompile, though i've had a massive data loss just after this so my ability may now be restricted until i get my build scripts back in order. Yeah fluidsynth is a bit of a pain and i'm not sure i'll get it working anytime soon . When you've ran with this for a week or two can you let me know if you have any issues please and if not i'll move to PR it for 4.4 E: Yep, this build script is gone. |
@bmn001 Has there been any issues? I'll soon recompile with zlib support as I forgot in the previous build so no zip files are accessible. If you don't mind testing this one too? Then we'll PR |
No issues that I could see. The previous build you provided is still going strong. Just a quick side note - the docs might need an update. They currently don't claim any kind of zip support for scummvm, and indicate that you need to create separate folders for each game. (https://onionui.github.io/docs/emulators/scummvm) I'm happy to test whatever you've got! |
Yeah, pretty sure at one point I added zlib support, then at another removed the zlib configure/compile and I don't remember why, was maybe it wasn't quite fully functional. I'll do another full compile with all our previous mods here aswell as zlib support so hopefully the zip files will work again & I'll include changes to docs in the PR, if it turns out to not work at all we'll just go ahead with the last working build. Thanks! |
Hey hey, So i've recompiled this evening. This is another clone from the master repo so it'll be as up to date as it gets but that may mean it brings some bugs up with it. Notable in this build:
Unfortunately this doesn't fix the fluidsynth issue, just haven't had the time to get it compiling The only testing i've done is adding a game (Beneath a Steel Sky) and running it to check vid/audio., Download: https://drive.google.com/file/d/1dRLwQVH_HjdHd2egq56v196amB1ccWMf/view?usp=sharing If you're having no issues with the previous build then we'll probably use that one to update Onions and close this issue with the PR 👍 As always, here's the engine data:
|
One week in on this new build and things seem be to running well! There is only one display issue that I can see, and I think it might be more on the Onion side than the ScummVM side: In some Scumm games (Secret of Monkey Island CD DOS is one, Police Quest II DOS is another), Onion's volume bar doesn't appear as a solid green line. It's a green vertical line, but every other row of pixels in that line is black, and the whole bar flickers. In these cases, a volume bar that shows "full" is actually only about 50% volume. You can continue to press the volume up button and the volume will increase, but it won't be reflected in the on-screen bar. |
A bit more info - this latest build fixes previously-unwatchable video playback in games like Myst, The 7th Guest, and Blade Runner! I looked into zlib - ScummVM uses it to decompress .dxa videos in some games and to compress/decompress save game data, but not to decompress the games themselves. They've said they will never support zipped games due to anti-piracy concerns. |
I’m still having issues with broken sword 2.5 audio. Then in the stand alone audio is fine but cursor movement is so slow. |
Checklist
Onions OS Version
4.3.0
Miyoo Firmware Version
202306282128
Provide a clear and concise description of the issue
TLDR: .flac and .m4a audio doesn't currently work in standalone ScummVM.
Per the ScummVM documentation, any games that shipped with CD audio tracks need to have those tracks ripped into one of four supported file formats: .mp3, .flac, .m4a, or .ogg.
The current standalone version of ScummVM included with Onion (2.9.0git) seems to only support two of these file formats: .ogg and .mp3. When audio is encoded in either format, games work fine.
However, if you attempt to launch a game with .flac audio tracks, the game will launch but you'll see this error: "This game has audio tracks on its CD. These tracks need to be ripped from the CD using an appropriate CD audio extracting tool in order to listen to the game's music. See the documentation (CD audio) for details." The game will be playable, but with no CD audio.
If you attempt to launch a game with .m4a audio tracks, the game will launch and you won't receive the error, but it will also not contain CD audio.
Steps to Reproduce
With .flac, you'll get an error message and no CD audio playback. With .m4a you won't get an error message, but you also won't have CD audio playback.
Provide any additional context or information that may help us investigate your issue
The ScummVM libretro core (2.7.0git) works as expected and supports all four file formats. This bug report only impacts the standalone/expert version.
The text was updated successfully, but these errors were encountered: