-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] iOS Null PushSubscription Id and Token crash #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes crash on iOS when calling OneSignal.User.PushSubscription.Id or OneSignal.User.PushSubscription.Token when vales are null. strdup only accounts for string parameters and not null
nan-li
approved these changes
Feb 2, 2024
Nit: I approved the PR but a ternary operator may simplify the code. Anytime there is logic along the lines of
|
jinliu9508
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good and easier to read comparing to using ternary operator.
jinliu9508
pushed a commit
that referenced
this pull request
Feb 23, 2024
[Fix] iOS Null PushSubscription Id and Token crash
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] iOS Null PushSubscription Id and Token crash
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] iOS Null PushSubscription Id and Token crash
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] iOS Null PushSubscription Id and Token crash
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] iOS Null PushSubscription Id and Token crash
jinliu9508
pushed a commit
that referenced
this pull request
Mar 1, 2024
[Fix] iOS Null PushSubscription Id and Token crash
jinliu9508
pushed a commit
that referenced
this pull request
Mar 4, 2024
[Fix] iOS Null PushSubscription Id and Token crash
jinliu9508
pushed a commit
that referenced
this pull request
Mar 4, 2024
[Fix] iOS Null PushSubscription Id and Token crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fixes crash on iOS when calling OneSignal.User.PushSubscription.Id or OneSignal.User.PushSubscription.Token when they are null.
Details
Motivation
Fixes iOS crash caused by calling
strdup
with a null parameter.Testing
Manual testing
Tested by initializing OneSignal with no wifi connection and calling OneSignal.User.PushSubscription.Id and OneSignal.User.PushSubscription.Token, app build with Unity 2022.3.10f1 with a fresh install of the OneSignal example app on a physical iPhone 12 with iOS 15.5.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is