Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] iOS Null PushSubscription Id and Token crash #697

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Feb 2, 2024

Description

One Line Summary

Fixes crash on iOS when calling OneSignal.User.PushSubscription.Id or OneSignal.User.PushSubscription.Token when they are null.

Details

Motivation

Fixes iOS crash caused by calling strdup with a null parameter.

Testing

Manual testing

Tested by initializing OneSignal with no wifi connection and calling OneSignal.User.PushSubscription.Id and OneSignal.User.PushSubscription.Token, app build with Unity 2022.3.10f1 with a fresh install of the OneSignal example app on a physical iPhone 12 with iOS 15.5.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Fixes crash on iOS when calling OneSignal.User.PushSubscription.Id or OneSignal.User.PushSubscription.Token when vales are null. strdup only accounts for string parameters and not null
@nan-li
Copy link

nan-li commented Feb 3, 2024

Nit: I approved the PR but a ternary operator may simplify the code. Anytime there is logic along the lines of if x: return x, else return y is a sign that a ternary operator may suffice.

return condition ? valueIfTrue : valueIfFalse

Copy link
Contributor

@jinliu9508 jinliu9508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good and easier to read comparing to using ternary operator.

@shepherd-l shepherd-l merged commit 79498b3 into user-model/main Feb 5, 2024
1 check passed
@shepherd-l shepherd-l deleted the fix/iOSNullPushSubIdAndToken branch February 5, 2024 20:14
jinliu9508 pushed a commit that referenced this pull request Feb 23, 2024
[Fix] iOS Null PushSubscription Id and Token crash
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
[Fix] iOS Null PushSubscription Id and Token crash
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
[Fix] iOS Null PushSubscription Id and Token crash
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
[Fix] iOS Null PushSubscription Id and Token crash
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
[Fix] iOS Null PushSubscription Id and Token crash
jinliu9508 pushed a commit that referenced this pull request Mar 1, 2024
[Fix] iOS Null PushSubscription Id and Token crash
jinliu9508 pushed a commit that referenced this pull request Mar 4, 2024
[Fix] iOS Null PushSubscription Id and Token crash
jinliu9508 pushed a commit that referenced this pull request Mar 4, 2024
[Fix] iOS Null PushSubscription Id and Token crash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants