-
Notifications
You must be signed in to change notification settings - Fork 142
Add support for Task<T>.Result usage #68
Comments
@ginach |
Thanks for reporting this. We need to talk this over internally to figure out the right thing to do here but feel free to submit a PR if you have specific changes in mind. |
Since this library can be invoked from UI threads, but does not really care about the SynchronizationContext (i.e. any thread pool thread is fine - we don't need the callbacks on the UI thread), we really should be using |
I meant to provide a PR for this but got involved in other projects, which kept me really busy. |
Unfortunately, this change will require changes to our code generation logic otherwise changes will be overwritten the next time we generate from the service. We do want to support this. I had to focus on the MS Graph SDK for a bit and hadn't been able to address the issue here until now. We're actually planning a V2 of the SDK to take in some breaking changes and I had been planning on making this fix then. That said, I can probably make this change sooner since it's not breaking. As an aside, if the OneDrive functionality you're using is currently supported by MS Graph you might want to check out that library. I made sure to build Task.Result support into it from the beginning. |
Fare enough. |
Thank you for reaching out and for your patience. This SDK is being officially deprecated. See #259 for more information |
Currently the SDK doesn't support the use of the
Result
property of anasync Task<T>
.When used it results to a deadlock.
Consider the use of
ConfigureAwait(false)
where applicable (mainly everywhere).P.S.: When I used
ConfigureAwait(false)
in all steps of aGetAsync()
call it worked. I know this isn't an easy undertaking but it should be done eventually.Justification: https://youtu.be/H4EmfpsYcfs?t=3966
The text was updated successfully, but these errors were encountered: