-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
date kwarg does not seem to work for get_dataframe() #71
Comments
Additional information. I reverted to version 0.3 and it seems that the the kwargs |
Thank you for the report, I can reproduce this behavior and will investigate further. I'm surprised that you had any trouble with version 0.3, since no changes were made to that version. As a workaround, you should be able to pull the whole series as a dataframe and slice down the the countries and years you're looking for. |
Bit of an update here. It seems that some of the problem was upstream, and has now been fixed. Unfortunately,
So that is your new workaround until I can fix this. |
I realized in looking at this that it isn't exactly a bug: that parameter is supposed to only take either a string, datetime, or 2-tuple of either. But it would probably be friendly to allow for lists since I doubt you're the only person who has tried this. |
Allow sequences of length 2 for dates even though it should *really* be a tuple. Contributes to #71. Signed-off-by: Oliver Sherouse <[email protected]>
Thank you for the update! After updating kwarg
data_date
todate
for theget_dataframe()
method, it does not seem to accept tuples as datetime objects or as strings. Bothwbdata.get_dataframe({"NY.GDP.MKTP.CD": "value"}, date=["2000", "2022"])
andyield error
TypeError: expected string or bytes-like object
with additional error logging point to this line in the_parse_date
method:The text was updated successfully, but these errors were encountered: