Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json can be invalid due to missing commas #7

Open
EternityForest opened this issue Jul 26, 2022 · 1 comment
Open

Json can be invalid due to missing commas #7

EternityForest opened this issue Jul 26, 2022 · 1 comment

Comments

@EternityForest
Copy link

In some cases, like when using a normal SD card that doesn't support the instructions, you get output like this, where commas are missing.

{
"version": "v0.4.0 (6778785) armv7",
"date": "2022-07-26T10:22:21.000Z",
"device":"/dev/mmcblk0",
"read_via_cmd56_arg_1":"not implemented: Operation timed out"
"idata.response[]":"0x900 0x00 0x00 0x00",
"error2":"2nd CMD56 CALL FAILED: Operation timed out"
}
@Ognian
Copy link
Owner

Ognian commented Jul 27, 2022

Thanks for reporting. This particular one should already be fixed in v0.4.1 and above.
Actually I should implement some helper function to generate the proper JSON output from an array, then errors like this one would be gone...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants