-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
241 dca 5 create the content upload and editing interface #269
241 dca 5 create the content upload and editing interface #269
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PR Description updated to latest commit (5f2aa14) |
PR Analysis
PR Feedback💡 General suggestions: The code looks well-structured and follows good practices. However, there are several TODO comments in the code where actions for file operations should be implemented. It's recommended to either implement these actions or, if they are planned for future PRs, provide more context in the comments about when and how these actions will be implemented. ✨ Usage guide:Overview:
With a configuration file, use the following template:
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Usage guide:Overview:
With a configuration file, use the following template:
See the improve usage page for a more comprehensive guide on using this tool. |
…types to fix compilation error 🔧 chore(EventSheet.stories.tsx): update event prop to include eventParameters.status to fix test expectations 🔧 chore(EventSheet.tsx): import EventStatusBadge component to display event status 🔧 chore(EventSheet.tsx): update SheetTitle component to include EventStatusBadge component 🔧 chore(event.query.gql): add eventParameters.status field to query to fetch event status 🚀 feat(ContentSpaceStatusBadge): add ContentSpaceStatusBadge component to display the status of a content space 🔄 refactor(ContentSpacesTable): update import path for ContentSpaceStatusBadge component to reflect its new location in the atoms folder 🔧 chore(content-spaces-types): add types for GetContentSpaceWithPassesOrganizerQuery and ContentSpaceFromOrganizerWithPasses to improve type safety 🆕 feat(ContentSpaceEventPassesTable.tsx): add new component ContentSpaceEventPassesTable to display event passes for a content space 🆕 feat(ContentSpaceFiles.tsx): add new component EventPassNftFiles to display NFT files for an event pass 🆕 feat(ContentSpaceSheet.tsx): add new component ContentSpaceSheet to display content space details and event passes 🆕 feat(pass-common): add getContentSpaceFolderPath function to generate the folder path for a content space 🔧 chore(contentSpace.query.gql): remove heroImage field from GetContentSpaceWithPassesOrganizer query as it is not used 🔨 refactor(page.tsx): remove unused imports and commented out code 🔨 refactor(index.ts): update import path for ContentSpacesPage component 🔨 refactor(ContentSpaceFiles.tsx): update import path for ContentSpaceNftFilesTable component 🔨 refactor(ContentSpaceSheet.tsx): update import paths for components and remove commented out code ✨ feat(ContentSpaceSheet.tsx): create ContentSpaceSheet component to display content space details and files ✨ feat(ContentSpacesPage.tsx): create ContentSpacesPage component to display a table of content spaces 📦 chore(content-spaces): add examples file for ContentSpaceEventPassesTable component 📦 chore(content-spaces): add ContentSpaceSheet component and its stories 🐛 fix(content-spaces): update translation key for go-back button in ContentSpaceSheet component 📦 chore(content-spaces): add examples file for ContentSpaceSheet component 🌐 feat(i18n): add translation for go-back button in ContentSpaceSheet component 🚀 feat(ContentSpaceSheet.tsx): add Accordion component to display associated event passes and files in ContentSpaceSheet 🌐 feat(en.json): add translation for "Associated Event Passes" in Sheet section 🔧 fix(content-space-common): remove unused code and export getContentSpaceFolderPath function 🔧 fix(gql): add id field to GetContentSpaceWithPassesOrganizer query to retrieve content space id 🔧 fix(deleteContentSpaceFile.spec.ts): fix import statement for FileWrapper and revalidateTag ✨ feat(deleteContentSpaceFile.ts): add deleteContentSpaceFile function to delete a file from a content space and revalidate cache 🔧 fix(deleteContentSpaceFiles.spec.ts): fix import statement for FileWrapper and revalidateTag ✨ feat(deleteContentSpaceFiles.ts): add deleteContentSpaceFiles function to delete multiple files from a content space and revalidate cache ✨ feat(getContentSpaceFiles.tsx): add getContentSpaceFiles function to get a list of files in a content space 🐛 fix(ContentSpaceEventPassesTable.tsx): remove unused import and fix indentation ✨ feat(ContentSpaceEventPassesTable.tsx): add support for translations using next-intl library to improve internationalization 🐛 fix(ContentSpaceFiles.tsx): remove unused import and fix indentation ✨ feat(ContentSpaceFiles.tsx): add ContentSpaceFilesUploader component to allow users to upload files to content space ✨ feat(ContentSpaceFilesTable.stories.tsx): create a new story file for ContentSpaceFilesTable component ✨ feat(ContentSpaceFilesTable.tsx): create ContentSpaceFilesTable component to display a table of content space files ✨ feat(ContentSpaceFilesTableClient.tsx): create ContentSpaceFilesTableClient component to render the content space files table using DataTable component ✨ feat(ContentSpaceFilesTableClient.tsx): add support for row selection and menu actions in the content space files table ✨ feat(ContentSpaceFilesTableClient.tsx): add ContentSpaceFilesUploader component to allow users to upload files to content space ✨ feat(ContentSpaceFilesTableClient.tsx): add support for deleting files from content space ✨ feat(ContentSpaceFilesTable/examples.tsx): create mocks for getContentSpaceFiles and deleteContentSpaceFile functions to be used in storybook examples 🚀 feat(ContentSpaceFilesUploader): add ContentSpaceFilesUploader component to allow users to upload files to a content space 🚀 feat(ContentSpaceFilesUploader): add support for displaying a loading skeleton while uploader session is not ready 🚀 feat(ContentSpaceFilesUploader): add support for fetching current files in the content space and displaying them in the uploader 🚀 feat(ContentSpaceFilesUploader): add support for uploading image files to the content space using the Bytescale upload widget 🚀 feat(ContentSpaceFilesUploader): add support for displaying a dialog with the uploader when the upload button is clicked 🚀 feat(ContentSpaceFilesUploader): add support for closing the dialog when the close button is clicked 🚀 feat(ContentSpaceFilesUploader): add support for showing a helper text with disabled reasons 🚀 feat(ContentSpaceFilesUploader): add support for showing a loading skeleton while uploader session is not ready 🚀 feat(ContentSpaceFilesUploader): add support for fetching current files in the content space and displaying them in the uploader 🚀 feat(ContentSpaceFilesUploader): add support for uploading image files to the content space using the Bytescale upload widget 🚀 feat(ContentSpaceFilesUploader): add support for displaying a dialog with the uploader when the upload button is clicked 🚀 feat(ContentSpaceFilesUploader): add support for closing the dialog when the close button is clicked 🚀 feat(ContentSpaceFilesUploader): add support for showing a helper text with disabled reasons 🚀 feat(ContentSpaceFilesUploader): add support for showing a loading skeleton while uploader session is not ready 🚀 feat(ContentSpaceFilesUploader): add support for fetching current files in the content space and displaying them in the uploader 🚀 feat(ContentSpaceFilesUploader): add support for uploading image files to the content space using the Bytescale upload widget 🚀 feat(ContentSpaceFilesUploader): add support for displaying a dialog with the uploader when the upload button is clicked 🚀 feat(ContentSpaceFilesUploader): add support for closing the dialog when the close button is clicked 🚀 feat(ContentSpaceFilesUploader): add support for showing a helper text with disabled reasons 🚀 feat(ContentSpaceFilesUploader): add support for showing a loading skeleton while uploader session is not ready 🚀 feat(ContentSpaceFilesUploader): add support for fetching current files in the content space and displaying them in the uploader 🔀 refactor(ContentSpaceFilesTable): update translation keys for better consistency and clarity 🔀 refactor(ContentSpaceFilesTableClient): update translation keys for better consistency and clarity 🔀 refactor(ContentSpaceFilesUploader): update translation keys for better consistency and clarity 🔀 refactor(ContentSpaceFilesUploaderClient): update translation keys for better consistency and clarity
5f2aa14
to
918fab5
Compare
…ontent component to fix runtime error 🔧 fix(NextIntlServer.mock.js): add missing getMessages function to fix runtime error
…evalidate tag name 🔧 chore(ContentSpaceFiles.tsx): remove unused import and commented out code 🔧 chore(tsconfig.lib.json): fix path to types folder 🔧 chore(.babelrc): remove unused file ✨ feat(.swcrc): add new configuration file for swc ✨ feat(package.json): add new package.json file for @features/back-office/events ✨ feat(project.json): add new build executor for @nx/js:swc 🔧 chore(tsconfig.lib.json): fix path to types folder 🔧 chore(en.json): add new translation for "files" 🔧 chore(fr.json): add new translation for "files"
Type
Enhancement
Description
ContentSpaceFilesTableClient
to display a table of files for a content space. The table includes functionalities such as file selection, file actions (show, download, delete), and batch actions for selected filesChanges walkthrough
ContentSpaceFilesTableClient.tsx
Added ContentSpaceFilesTableClient component
libs/features/back-office/content-spaces/src/lib/organisms/ContentSpaceFilesTable/ContentSpaceFilesTableClient.tsx
ContentSpaceFilesTableClient.tsx
which is acomponent to display a table of files for a content space.
actions (show, download, delete), and batch actions for selected files.
ContentSpaceFilesUploaderClient.tsx
Added ContentSpaceFilesUploaderClient component
libs/features/back-office/content-spaces/src/lib/organisms/ContentSpaceFilesUploader/ContentSpaceFilesUploaderClient.tsx
ContentSpaceFilesUploaderClient.tsx
which is acomponent to upload files for a content space.
index.ts
Updated GraphQL query types
libs/gql/admin/types/src/generated/index.ts
GetContentSpaceWithPassesOrganizerQuery
andGetEventWithPassesOrganizerQuery
types to include theid
field andeventParameters.status
field respectively.ContentSpaceFilesTable.stories.tsx
Added Storybook story for ContentSpaceFilesTable component
libs/features/back-office/content-spaces/src/lib/organisms/ContentSpaceFilesTable/ContentSpaceFilesTable.stories.tsx
ContentSpaceFilesTable
component.
deleteContentSpaceFiles.spec.ts
Added unit tests for deleteContentSpaceFiles action
libs/features/back-office/content-spaces/src/lib/actions/deleteContentSpaceFiles.spec.ts
deleteContentSpaceFiles
action.✨ Usage guide:
Overview:
The
describe
tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.When commenting, to edit configurations related to the describe tool (
pr_description
section), use the following template:With a configuration file, use the following template:
Enabling\disabling automation
meaning the
describe
tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description.the tool will replace every marker of the form
pr_agent:marker_name
in the PR description with the relevant content, wheremarker_name
is one of the following:type
: the PR type.summary
: the PR summary.walkthrough
: the PR walkthrough.Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.
Custom labels
The default labels of the
describe
tool are quite generic: [Bug fix
,Tests
,Enhancement
,Documentation
,Other
].If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:
Main topic:performance
- pr_agent:The main topic of this PR is performanceNew endpoint
- pr_agent:A new endpoint was added in this PRSQL query
- pr_agent:A new SQL query was added in this PRDockerfile changes
- pr_agent:The PR contains changes in the DockerfileThe list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
Inline File Walkthrough 💎
For enhanced user experience, the
describe
tool can add file summaries directly to the "Files changed" tab in the PR page.This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).
To enable inline file summary, set
pr_description.inline_file_summary
in the configuration file, possible values are:'table'
: File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.true
: A collapsable file comment with changes title and a changes summary for each file in the PR.false
(default): File changes walkthrough will be added only to the "Conversation" tab.Utilizing extra instructions
The
describe
tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.
Examples for extra instructions:
Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
More PR-Agent commands
See the describe usage page for a comprehensive guide on using this tool.