From 49628776b748718edabc5e1c8109736bdb9b2648 Mon Sep 17 00:00:00 2001 From: Daniel Oliveira Date: Fri, 18 Aug 2023 16:34:31 +0200 Subject: [PATCH 1/4] Check issuer before options --- pkg/reconcilers/ingress_reconciler.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/reconcilers/ingress_reconciler.go b/pkg/reconcilers/ingress_reconciler.go index fe92b13..6bda6ff 100644 --- a/pkg/reconcilers/ingress_reconciler.go +++ b/pkg/reconcilers/ingress_reconciler.go @@ -55,7 +55,10 @@ func (r *IngressReconciler) reconcileNotFound(ctx context.Context, gs *agonesv1. WithCustomAnnotationsTemplate(), WithIngressRule(mode), WithTLS(mode), - WithTLSCertIssuer(issuer), + } + + if issuer != "" { + opts = append(opts, WithTLSCertIssuer(issuer)) } ingress, err := newIngress(gs, opts...) From b6e6950ace3368df38812d5b07b1ae816bd56ac4 Mon Sep 17 00:00:00 2001 From: Daniel Oliveira Date: Fri, 18 Aug 2023 16:34:46 +0200 Subject: [PATCH 2/4] Bump Release Tag 0.2.8 --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index f997591..3e4e0d8 100644 --- a/Makefile +++ b/Makefile @@ -36,7 +36,7 @@ OCTOPS_BIN := bin/octops-controller IMAGE_REPO=octops/gameserver-ingress-controller DOCKER_IMAGE_TAG ?= octops/gameserver-ingress-controller:${VERSION} -RELEASE_TAG=0.2.7 +RELEASE_TAG=0.2.8 default: clean build From 4ed8b2293f37673a0fff6fd03c1397f73d5e9899 Mon Sep 17 00:00:00 2001 From: Daniel Oliveira Date: Fri, 18 Aug 2023 16:49:32 +0200 Subject: [PATCH 3/4] Update install manifest to latest image 0.2.8 --- deploy/install.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/install.yaml b/deploy/install.yaml index dce35e9..e1ed36a 100644 --- a/deploy/install.yaml +++ b/deploy/install.yaml @@ -69,7 +69,7 @@ spec: spec: serviceAccountName: octops-ingress-controller containers: - - image: octops/gameserver-ingress-controller:0.2.7 # Latest release + - image: octops/gameserver-ingress-controller:0.2.8 # Latest release name: controller ports: - containerPort: 30235 From 4b23c848af3d906386c587218076cd0f9455c604 Mon Sep 17 00:00:00 2001 From: Daniel Oliveira Date: Thu, 4 Jan 2024 18:13:59 +0100 Subject: [PATCH 4/4] Update release tag to 0.2.9 --- Makefile | 2 +- deploy/install.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 3e4e0d8..e4e8f23 100644 --- a/Makefile +++ b/Makefile @@ -36,7 +36,7 @@ OCTOPS_BIN := bin/octops-controller IMAGE_REPO=octops/gameserver-ingress-controller DOCKER_IMAGE_TAG ?= octops/gameserver-ingress-controller:${VERSION} -RELEASE_TAG=0.2.8 +RELEASE_TAG=0.2.9 default: clean build diff --git a/deploy/install.yaml b/deploy/install.yaml index e1ed36a..4ddd58a 100644 --- a/deploy/install.yaml +++ b/deploy/install.yaml @@ -69,7 +69,7 @@ spec: spec: serviceAccountName: octops-ingress-controller containers: - - image: octops/gameserver-ingress-controller:0.2.8 # Latest release + - image: octops/gameserver-ingress-controller:0.2.9 # Latest release name: controller ports: - containerPort: 30235