Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use Oceananigans v0.92.1 #225

Merged
merged 7 commits into from
Oct 24, 2024

Conversation

ali-ramadhan
Copy link
Collaborator

As of Oceananigans v0.92.1 (and PR CliMA/Oceananigans.jl#3732), TracerAdvection is now called FluxFormAdvection so this PR just updates the code.

I thought it warranted tagging v0.93.0 but I guess TracerAdvection was not exported so it's not technically a breaking change in terms of the public interface.

@ali-ramadhan ali-ramadhan requested a review from jagoosw October 23, 2024 21:49
Copy link
Collaborator

@jagoosw jagoosw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sorting this out! We should change the version and release a patch here too

@ali-ramadhan
Copy link
Collaborator Author

Good idea! I just bumped v0.13.1. Will merge once tests (hopefully) pass.

@ali-ramadhan ali-ramadhan merged commit 54cfd8a into main Oct 24, 2024
5 checks passed
@ali-ramadhan ali-ramadhan deleted the ali/upgrade-to-oceananigans-0.92.1 branch October 24, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants