-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Oceananigans to 0.90 #157
Conversation
We need to update the example in the |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
=======================================
Coverage 64.18% 64.19%
=======================================
Files 27 27
Lines 1061 1064 +3
=======================================
+ Hits 681 683 +2
- Misses 380 381 +1
☔ View full report in Codecov by Sentry. |
This is now failing from a bug in Oceananigans, I'll make a PR there (CliMA/Oceananigans.jl#3383) and maybe just change how the temperature is set in this example for now (since it doesn't have any movement it can just be a function field instead). |
Actually changing this example to have a function field makes it quite messy since T is a tracer required by the bgc model so we would have to predefined all of the tracers like:
Which takes away from our demonstration of the automatic setup. I am going to try and run the example with a temperature forcing that is the derivative of the prescribed temperature and see if the time resolution is sufficient for it to work correctly. |
We can just do a minor update when all three are merged? |
Oh yeah I meant patch but we can just merge them all and do a minor release when #155 is merged |
Some (internal) fixes required for light attenuation.