Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add citation info in README + Docs #148

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Add citation info in README + Docs #148

merged 3 commits into from
Oct 6, 2023

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented Oct 5, 2023

No description provided.

@navidcy navidcy requested a review from jagoosw October 5, 2023 18:32
@navidcy
Copy link
Collaborator Author

navidcy commented Oct 5, 2023

Perhaps we should add something in the Docs as well?

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (83e11aa) 65.78% compared to head (2184ca3) 65.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   65.78%   65.78%           
=======================================
  Files          27       27           
  Lines        1064     1064           
=======================================
  Hits          700      700           
  Misses        364      364           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jagoosw
Copy link
Collaborator

jagoosw commented Oct 6, 2023

I guess so, probably just the exact same on the home page?

@jagoosw
Copy link
Collaborator

jagoosw commented Oct 6, 2023

I think there is a mention about citing it on that page that can just be updated actually

@navidcy
Copy link
Collaborator Author

navidcy commented Oct 6, 2023

Yes, true. I’ll do that ;)

@navidcy navidcy changed the title Add citation section in README Add citation info in README + Docs Oct 6, 2023
@navidcy navidcy added the documentation Improvements or additions to documentation label Oct 6, 2023
Copy link
Collaborator

@jagoosw jagoosw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@navidcy navidcy merged commit b413571 into main Oct 6, 2023
4 checks passed
@navidcy navidcy deleted the ncc/readme branch October 6, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants