Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support v1.8.0 #31

Merged
merged 12 commits into from
Mar 18, 2024
Merged

support v1.8.0 #31

merged 12 commits into from
Mar 18, 2024

Conversation

HananINouman
Copy link
Collaborator

@HananINouman HananINouman commented Mar 12, 2024

This PR refactor the lock verification function, and it adds keys and support for v1.8.0.
But v1.7.0 is still used in cluster creation.

@HananINouman HananINouman requested a review from a team as a code owner March 12, 2024 23:11
@HananINouman HananINouman marked this pull request as draft March 13, 2024 11:31
@HananINouman HananINouman marked this pull request as ready for review March 13, 2024 19:27
Copy link
Collaborator

@LukeHackett12 LukeHackett12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm mostly formatting comments

src/verification/common.ts Outdated Show resolved Hide resolved
src/verification/common.ts Outdated Show resolved Hide resolved
src/verification/common.ts Outdated Show resolved Hide resolved
src/verification/common.ts Outdated Show resolved Hide resolved
src/verification/common.ts Outdated Show resolved Hide resolved
src/verification/v1.7.0.ts Outdated Show resolved Hide resolved
src/verification/v1.8.0.ts Show resolved Hide resolved
test/sdk-package-test/cluster.test.ts Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
25.6% Duplication on New Code

See analysis details on SonarCloud

@HananINouman HananINouman merged commit 9905321 into main Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants