Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warn log when validator API receives a request on /eth/v2/validator/blocks/* #3405

Open
5 tasks
OisinKyne opened this issue Dec 6, 2024 · 0 comments
Open
5 tasks
Assignees
Labels
protocol Protocol Team tickets
Milestone

Comments

@OisinKyne
Copy link
Contributor

🎯 Problem to be solved

It is hard to debug why a node is attesting but not taking part in proposals. One reason is that they are still using the deprecated produceBlockV2 endpoint.

If we output a warn log when this method is called, (Like "Requested a block from the deprecated V2 endpoint") and a docs FAQ > Errors and Resolutions entry to explain how to fix it, it may reduce issues debugging this in future.

🛠️ Proposed solution

  • Approved design doc: link
  • Core team consensus on the proposed solution

Describe the solution to be implemented

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet
@github-actions github-actions bot added the protocol Protocol Team tickets label Dec 6, 2024
@OisinKyne OisinKyne changed the title Add a warn log when validator API receives a request on /eth/v2/validator/blocks/* Add a warn log when validator API receives a request on /eth/v2/validator/blocks/* Dec 6, 2024
@OisinKyne OisinKyne added this to the v1.3.0 milestone Dec 12, 2024
@pinebit pinebit self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

2 participants