-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r.what: Update to handle more than 400 bands #4823
base: main
Are you sure you want to change the base?
Conversation
AVIRIS-NG has 425 bands, i.spectral is using r.what in the background has fails for hyperspectral imagery having bands more than 400.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason why the number of files has a hardcoded limit? Is it something that should be documented?
I do not know, 400 images was really a lot in the old times |
Now you showed a valid, real-world use case for more than 400 files! |
Should probably be backported to 8.4. |
Cool! There are several other use cases where overcoming that limitation is very useful. Just one question: Did you consider using |
@@ -18,7 +18,7 @@ | |||
* for details. | |||
* | |||
*****************************************************************************/ | |||
#define NFILES 400 | |||
#define NFILES 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about 1024 (I think a few hyperspectral cameras offering that).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "TODO Fix 400 maps limit" needs to be removed from the HTML manual page file.
AVIRIS-NG has 425 bands, i.spectral is using r.what in the background has fails for hyperspectral imagery having bands more than 400.