Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abstract_space_time_dataset: use keyword arguments in calls to get_registered_maps #4068

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

ninsbl
Copy link
Member

@ninsbl ninsbl commented Jul 17, 2024

Calling get_registered_maps_as_objects may fail, depending on the arguments provided. This PR backports a fix in how the underlying get_registered_maps method is called.

See also: #3798

@ninsbl ninsbl added bug Something isn't working temporal Related to temporal data processing libraries labels Jul 17, 2024
@ninsbl ninsbl added this to the 8.4.1 milestone Jul 17, 2024
@github-actions github-actions bot added the Python Related code is in Python label Jul 17, 2024
@echoix
Copy link
Member

echoix commented Jul 17, 2024

Since 8.4 isn't even out yet, is there a real issue to hold it back?

@ninsbl
Copy link
Member Author

ninsbl commented Jul 17, 2024

Since 8.4 isn't even out yet, is there a real issue to hold it back?

Not from my side. I just don`t want to interfer with the release process or cause more delay because a new RC might needed...

@echoix echoix requested a review from neteler July 18, 2024 22:35
@echoix
Copy link
Member

echoix commented Jul 18, 2024

@neteler I'm letting you decide to merge now or later, but if it's later, can you mention it so I don't think that the PR is forgotten if it ends up unmerged for too long?

@neteler
Copy link
Member

neteler commented Jul 19, 2024

To be honest, I cannot judge this one.

@echoix
Copy link
Member

echoix commented Jul 19, 2024

To be honest, I cannot judge this one.

That's why I only need you to decide when to merge the backport, the contents is fine

@neteler
Copy link
Member

neteler commented Jul 19, 2024

Since it is marked 8.4.1 we still have to wait that 8.4.0 gets out of the door. See related discussion on grass-dev.

@echoix
Copy link
Member

echoix commented Aug 1, 2024

Since it is marked 8.4.1 we still have to wait that 8.4.0 gets out of the door. See related discussion on grass-dev.

8.4.0 is out, so it is ready now?

@neteler
Copy link
Member

neteler commented Aug 2, 2024

From the release management perspective: yes

@echoix
Copy link
Member

echoix commented Aug 5, 2024

Since there were no objections in at least 4 days after the last comment, I'm taking the liberty to merge

@echoix echoix merged commit 048490f into OSGeo:releasebranch_8_4 Aug 5, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libraries Python Related code is in Python temporal Related to temporal data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants