-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abstract_space_time_dataset: use keyword arguments in calls to get_registered_maps #4068
Conversation
Since 8.4 isn't even out yet, is there a real issue to hold it back? |
Not from my side. I just don`t want to interfer with the release process or cause more delay because a new RC might needed... |
@neteler I'm letting you decide to merge now or later, but if it's later, can you mention it so I don't think that the PR is forgotten if it ends up unmerged for too long? |
To be honest, I cannot judge this one. |
That's why I only need you to decide when to merge the backport, the contents is fine |
Since it is marked 8.4.1 we still have to wait that 8.4.0 gets out of the door. See related discussion on grass-dev. |
8.4.0 is out, so it is ready now? |
From the release management perspective: yes |
Since there were no objections in at least 4 days after the last comment, I'm taking the liberty to merge |
Calling
get_registered_maps_as_objects
may fail, depending on the arguments provided. This PR backports a fix in how the underlyingget_registered_maps
method is called.See also: #3798