-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r.category: add JSON support #4018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kritibirda26 overall this looks good.
I have a few thoughts about some additional features we could add, but they are outside of the scope of this PR. So, just for a quick discussion should we make some new feature issues for the following ideas.
- Color option - We should add a new option that outputs the category color. In any use case where the user wants to create a visualization they will want to know the category label and color.
- JSON input - Allow user to use json as the rules file. As part of this we might just want to look at a way to allow this for all spots where we have a text rules files.
Hi @cwhite911 and @echoix, I have updated the PR according to the feedback and created issues for the suggested new features. The PR should be ready to merge. |
I have nothing to say against, but I would prefer another approval to be confident. |
* r.category: add JSON support * add test and docs * address PR feedback
The JSON output looks as follows:
Note that the format option for this module is named as
output_format
becauseformat
is being used as the name for another option.