Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: Add imagery Python library module to grass.script #3756

Merged
merged 22 commits into from
Dec 11, 2024

Conversation

ninsbl
Copy link
Member

@ninsbl ninsbl commented May 31, 2024

This PR adds a new imagery module to grass.script. For the time being it has just one function, that returns a dictionary for an imagery group with the contained maps and metadata.

It addresses #3750

@ninsbl ninsbl added enhancement New feature or request Python Related code is in Python libraries imagery labels May 31, 2024
@ninsbl ninsbl added this to the Future milestone May 31, 2024
@github-actions github-actions bot added the tests Related to Test Suite label May 31, 2024
python/grass/script/imagery.py Outdated Show resolved Hide resolved
python/grass/script/imagery.py Outdated Show resolved Hide resolved
python/grass/script/imagery.py Outdated Show resolved Hide resolved
python/grass/script/imagery.py Outdated Show resolved Hide resolved
python/grass/script/imagery.py Outdated Show resolved Hide resolved
python/grass/script/imagery.py Outdated Show resolved Hide resolved
python/grass/script/imagery.py Outdated Show resolved Hide resolved
python/grass/script/imagery.py Outdated Show resolved Hide resolved
python/grass/script/imagery.py Outdated Show resolved Hide resolved
python/grass/script/imagery.py Outdated Show resolved Hide resolved
echoix
echoix previously requested changes Jun 4, 2024
python/grass/script/testsuite/test_imagery.py Outdated Show resolved Hide resolved
@ninsbl ninsbl requested review from wenzeslaus and echoix June 5, 2024 21:46
@echoix echoix dismissed their stale review June 5, 2024 21:50

Changes addressed

@ninsbl ninsbl modified the milestones: Future, 8.5.0 Jun 15, 2024
@ninsbl ninsbl requested a review from wenzeslaus July 17, 2024 22:08
python/grass/script/testsuite/test_imagery.py Outdated Show resolved Hide resolved
python/grass/script/testsuite/test_imagery.py Outdated Show resolved Hide resolved
python/grass/script/testsuite/test_imagery.py Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@echoix
Copy link
Member

echoix commented Jul 19, 2024

One last question about this one: does it wire up everything in order for the sphinx docs to be generated correctly for it? For the makefiles it is probably enough, I didn't search more.

python/grass/script/imagery.py Show resolved Hide resolved
python/grass/script/imagery.py Outdated Show resolved Hide resolved
python/grass/script/imagery.py Outdated Show resolved Hide resolved
@ninsbl ninsbl requested a review from wenzeslaus September 8, 2024 19:54
@ninsbl
Copy link
Member Author

ninsbl commented Dec 10, 2024

@wenzeslaus would you mind having a look at this if your requested changes are properly addressed and approve or comment?

@ninsbl ninsbl enabled auto-merge (squash) December 10, 2024 10:54
@ninsbl ninsbl dismissed wenzeslaus’s stale review December 11, 2024 09:23

Requested changes are adressed

@ninsbl ninsbl merged commit 3b5184f into OSGeo:main Dec 11, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request imagery libraries Python Related code is in Python tests Related to Test Suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants