init: Remove automatic vacuum #2449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes automatic vacuum of SQLite database, i.e., reverts the addition of automatic vacuum when a session ends. Doing vacuum can take long time which the current implementation hides by running the vacuum process in the background. The typical time is much longer than the 0.1 sec suggested by the sleep call. Doing vacuum only sometimes would be less predictable for the users and doing it only for large database would mean that it will take really long time (with a lot of disk or memory usage) when it actually happens suggesting that that's something user may want to trigger manually. Notably, SQLite doesn't do the vacuums automatically, although PostgreSQL has autovacuum on by default. This is an alternative to OSGeo#2377 which uses VACUUM for large, modified files only.
Introduced in SQLite 3.1, auto_vacuum is an optional feature that automatically vacuums the database to minimize the size of the database file. With this feature, you don't have to manually run the VACUUM statement. By default, the auto_vacuum feature is disabled. |
|
This works well with #2462 which supports user in doing vacuum when needed and enable auto-vacuum (only draft now). |
wenzeslaus
added
bug
|
The #2377 (vacuum for large and modified only) is merged, so closing this one. However, removing vacuum completely, i.e., leaving it up to the user and database would still make it faster for many users. Open a new issue or PR if you want that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes automatic vacuum of SQLite database, i.e., reverts the addition of automatic vacuum when a session ends.
Doing vacuum can take long time which the current implementation hides by running the vacuum process in the background. The typical time is much longer than the 0.1 sec suggested by the sleep call.
Doing vacuum only sometimes would be less predictable for the users and doing it only for large database would mean that it will take really long time (with a lot of disk or memory usage) when it actually happens suggesting that that's something user may want to trigger manually.
Notably, SQLite doesn't do the vacuums automatically, although PostgreSQL has autovacuum on by default.
This is an alternative to #2377 which uses VACUUM for large, modified files only.