-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corona does not change color on hover #29
Comments
while hospitality to corona was solved, the code was implemented very differently from the other icons on the site, with 2 images being uploaded specifically for this purpose (I'm guessing - correct me if I'm wrong here). It might be simpler to stick to font-awesome. use fa-glass or something. If we really absolutely must have the 2 beer mugs - maybe run all our icon fonts through icomoon or something? |
@kaivalyar : Yeah, you are right, two icons were used. Even, I think that the image is an overhead, and moreover not going in with the others. I have not come across icomoon till now, I'll have a look. BTW @utkarshme , Kaivalya has a point, and do you think we need a separate image or can we manage with a font-awesome icon. PS: Maybe fa-beer will be a better option than fa-glass :P |
I had tried both out before commenting itself - glass seems to go better with the site than beer, IMHO. If you want to go with this idea, i'd be happy to make this edit. |
I'll take a confirmation from the DoCW side, before. |
I think it's fine too. |
Ummm ... DoCW want's to overlook the performance overhead too? I mean ... we're going to start uploading images for this? |
@utkarshme : Can you solve the issue?
The text was updated successfully, but these errors were encountered: