Skip to content
This repository has been archived by the owner on Apr 7, 2021. It is now read-only.

Shall not modify /etc/logrotate #44

Open
duck-rh opened this issue Sep 27, 2017 · 4 comments
Open

Shall not modify /etc/logrotate #44

duck-rh opened this issue Sep 27, 2017 · 4 comments

Comments

@duck-rh
Copy link
Contributor

duck-rh commented Sep 27, 2017

/etc/logrotate.conf is a global configuration and this has nothing to do with configuring Apache Httpd and related vhosts or web services. We should strive to respect roles' perimeters.
/etc/logrotate.d/httpd is the right file to modify.

@duck-rh
Copy link
Contributor Author

duck-rh commented Sep 27, 2017

I'm considering using this role for DuckCorp, but there's quite some work to make it working on Debian. I should be able to provide a patch, should you agree on this (that is to say: don't work on it, just give your opinion please).

@mscherer
Copy link
Contributor

mscherer commented Oct 4, 2017

The logrotation setting is not a default one, so I think that's minor. And the setting date back to manageiq, on RHEL 6 so I do not have context on why we would want that.

I would be in favor of removing it all together, and let people configure logging outside of the role.

@duck-rh
Copy link
Contributor Author

duck-rh commented Oct 4, 2017

I'm fine with this plan.

I can work on this but as said, not on the current master.

duck-rh added a commit that referenced this issue Oct 10, 2017
This is outside the scope of this role (see #44).
@duck-rh
Copy link
Contributor Author

duck-rh commented Oct 12, 2017

It is fixed in 135cc0b

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants