Wrong calculation of INDEX_IJK #12023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnesj
force-pushed
the
12021-wrong-index-ijk
branch
from
7db1319 to
67928fa
Compare
INDEX_I INDEX_J INDEX_K are result properties computed by ResInsight. When using opm-common, only active cells are defined. In this situation, the computation fails. Change the implementation to compute these values only for active cells. This will also improve performance and use less memory.
magnesj
force-pushed
the
12021-wrong-index-ijk
branch
from
67928fa to
334d66c
Compare
jonjenssen
reviewed
Jan 3, 2025
ApplicationLibCode/ReservoirDataModel/ResultCalculators/RigFaultDistanceResultCalculator.cpp
Show resolved
Hide resolved
jonjenssen
approved these changes
Jan 3, 2025
magnesj
force-pushed
the
12021-wrong-index-ijk
branch
from
1085282 to
27e0ab0
Compare
magnesj
force-pushed
the
12021-wrong-index-ijk
branch
from
27e0ab0 to
2873b23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12021