[Server] Fix: Return full CertificateChain after Certificate Update

[romanett]

Proposed changes

Fix the CertificateTypesProvider to also return the correct chain after a CertificateUpdate occured.

Related Issues

• Fixes #

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds functionality)
• Test enhancement (non-breaking change to increase test coverage)
• Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
• Documentation Update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc.
• I have signed the CLA.
• I ran tests locally with my changes, all passed.
• I fixed all failing tests in the CI pipelines.
• I fixed all introduced issues with CodeQL and LGTM.
• I have added tests that prove my fix is effective or that my feature works and increased code coverage.
• I have added necessary documentation (if appropriate).
• Any dependent changes have been merged and published in downstream modules.

[codecov]

Codecov Report

Attention: Patch coverage is 78.04878% with 9 lines in your changes missing coverage. Please review.

Project coverage is 55.30%. Comparing base (ce33d63) to head (bef4079).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
.../Security/Certificates/CertificateTypesProvider.cs	78.57%	1 Missing and 2 partials ⚠️
...a.Server/Configuration/ConfigurationNodeManager.cs	81.81%	2 Missing ⚠️
...ndings.Https/Stack/Https/HttpsTransportListener.cs	0.00%	2 Missing ⚠️
Stack/Opc.Ua.Core/Stack/Server/ServerBase.cs	85.71%	0 Missing and 1 partial ⚠️
....Ua.Core/Stack/Tcp/UaSCBinaryChannel.Asymmetric.cs	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2855      +/-   ##
==========================================
- Coverage   55.70%   55.30%   -0.41%     
==========================================
  Files         352      352              
  Lines       67332    67342      +10     
  Branches    13806    13805       -1     
==========================================
- Hits        37506    37241     -265     
- Misses      25792    26019     +227     
- Partials     4034     4082      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mregen]

This change contradicts the idea of the cache, which was that certs and certchains are being updated outside the normal create session flows, once.
Then no async load operation has to be done and no async has to be wired up.

[romanett]

@mregen but shouldn't we handle a "Cache miss". I can change the logic back to a separate update function, If we don't need this

[mregen]

Question is why we have a cache miss, it should be loaded once on startup, or when application certificates are updated. handling the cache miss is a band aid.

[romanett]

okay, I will rewrite to loop all security policies to update each of the application certificates on certificate update. I did not think the async overhead was such a concern.