Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx1-2: Mapping missing for field I.3.3.1 "Additional information can be obtained from" "The above mentioned address" #258

Closed
csnyulas opened this issue Nov 30, 2022 · 3 comments
Assignees
Labels
act: for closing it can be closed but an additional confirmation is needed type: bug Something implemented incorrectly in a release.
Milestone

Comments

@csnyulas
Copy link
Contributor

csnyulas commented Nov 30, 2022

Context F21
[comment from N Muric]

I.3.3.1 No mapping there should be a mapping to the address of the buyer as the ProcurementProcedureInformationProvider for this row

image

E.g. In 034993-2022 there is no mapping for this

Conclusion: Mapping (both technical and conceptual) for field I.3.3.1, corresponding to XPath CONTRACTING_BODY/ADDRESS_FURTHER_INFO_IDEM is missing

@csnyulas csnyulas self-assigned this Nov 30, 2022
@csnyulas csnyulas added the type: bug Something implemented incorrectly in a release. label Nov 30, 2022
@csnyulas csnyulas added this to the 2022-12 milestone Nov 30, 2022
@csnyulas
Copy link
Contributor Author

Conceptual mapping was added in version 4.1.0

image

Where in CL1the AgentInRole for such cases will be epo:ProcurementProcedureInformationProvider

image

csnyulas added a commit that referenced this issue Dec 6, 2022
@csnyulas csnyulas added the act: for closing it can be closed but an additional confirmation is needed label Dec 6, 2022
@csnyulas csnyulas closed this as completed Dec 6, 2022
@muricna
Copy link

muricna commented Jan 18, 2023

1.3.3.1 When there is more than one buyer and therefore more than one address above should there not both addresses be foreseen.

@csnyulas
Copy link
Contributor Author

I opened a separate ticket (#333) for the question raised by @muricna in her last comment, i.e. about how to deal with mapping "The above mentioned address" that appears in field I.3.3.1 (XPath: CONTRACTING_BODY/ADDRESS_FURTHER_INFO_IDEM) and I.3.4.2 (XPath: CONTRACTING_BODY/ADDRESS_PARTICIPATION_IDEM), when there are multiple buyers.

That question is a related, but a separate, issue from what this issue was about, namely the missing technical mapping for the field I.3.3.1. This issue (about creating the appropriate epo:ProcurementProcedureInformationProvider and/or epo:TenderReceiver instances when ADDRESS_FURTHER_INFO_IDEM and/or ADDRESS_PARTICIPATION_IDEM XML element is present) has been fixed, as was demonstrated the previous comments, and can be seen when looking at the linked commits.

So, I will mark again this issue as Fixed, and will close it. The question about additional buyer should be dealt with in #333.

@csnyulas csnyulas added act: for closing it can be closed but an additional confirmation is needed and removed question labels Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
act: for closing it can be closed but an additional confirmation is needed type: bug Something implemented incorrectly in a release.
Projects
None yet
Development

No branches or pull requests

2 participants