QSSTV broken with latest hamlib

[sjlongland]

Hi,

I've been debugging an issue with Hamlib where it intermittently toggles the VFO, which wears out relays in the transceiver and causes quite a lot of pain with receiving SSTV transmissions unless both VFOs happen to be on the same frequency.

Hamlib/Hamlib#1576 has the background, I'm experiencing this with a Yaesu FT-897D. Hence I updated to the latest release, that seems to have cured the VFO switching issue, but has broken QSSTV.

Platform is Debian Linux (Raspbian) Bookworm on armhf. Hardware is a Raspberry Pi 4 8GB + NWDR DRAWS radio interface, with a USB pl2303-based CAT transceiver cable for the CAT connection. I am not able to access DTR/RTS pins on said CAT transceiver cable.

When I compile QSSTV against the current latest Hamlib master branch (commit 8b9c768), either QSSTV 9.5.8 (from Debian's source tree) or master branch, QSSTV reports "No Rig" in the frequency display, and fails to engage PTT on the transceiver when transmitting.

The only other way I can key the transceiver, is via /sys/class/gpio, which QSSTV does not support.

I am able to successfully engage PTT with the command rigctl -m 2 -r localhost:4532 --skipinit T 1 and release it with rigctl -m 2 -r localhost:4532 --skipinit T 0. (as well as values 2 and 3, these all engage PTT as well.)

I've tried running rigctld with and without --vfo.

I suspect Hamlib is failing to initialise with the new release, and this is therefore why PTT is not working.

[SpudGunMan]

../rig/rigcontrol.cpp:324:24: error: invalid conversion from ‘int (*)(const rig_caps*, void*)’ to ‘int (*)(rig_caps*, void*)’ [-fpermissive]
  324 |       rig_list_foreach(collect,0);
      |                        ^~~~~~~
      |                        |
      |                        int (*)(const rig_caps*, void*)
In file included from ../rig/rigcontrol.h:4,
                 from ../rig/rigcontrol.cpp:21:
/usr/local/include/hamlib/rig.h:3792:18: note:   initializing argument 1 of ‘int rig_list_foreach(int (*)(rig_caps*, void*), void*)’
 3792 | rig_list_foreach HAMLIB_PARAMS((int (*cfunc)(struct rig_caps *, rig_ptr_t),
      |                  ^~~~~~~~~~~~~
make: *** [Makefile:4883: rigcontrol.o] Error 1